Repository navigation
RDCON - BUGFIX - Delta-matrix output formats sized with i0 - #302
Merged
Merged
Conversation
The delta_gw.out and related Delta-matrix headers used i2.2 for the number of singular surfaces. At 25 or more surfaces the repeat count overflowed to '**' and rdcon crashed writing delta_gw.out. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
3 tasks done
StuartBenjamin
marked this pull request as draft
October 13, 2026 07:24
StuartBenjamin
requested review from
matt-pharr
and removed request for
d-burg
October 13, 2026 08:08
StuartBenjamin
marked this pull request as ready for review
October 13, 2026 09:25
matt-pharr
approved these changes
Oct 15, 2026
matt-pharr
left a comment
matt-pharr
left a comment
Collaborator
There was a problem hiding this comment.
Essentially inconsequential unless you are using ascii IO but this is fine
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With 25 or more singular surfaces RDCON stops while writing
delta_gw.out: "Fortran runtime error: Left parenthesis required after '*'".gal_write_deltawrites the repeat counts (2·msing, 4·msing) into its run-time formats withi2.2, and 4·msing ≥ 100 prints as**. The DIII-D example has 40 surfaces at n = 8.Fix: write the counts with
i0(three format lines inrdcon/gal.f). Output with fewer than 25 surfaces is unchanged.Test: DIIID_resistive_example at
nn=8(40 surfaces; nx 32,delta_mlow = delta_mhigh = 2, no wall, RPEC/MRE/bin_delmatchoff to keep it cheap).gal.f:1505delta_gw.outNot fixed (cosmetic): the column labels use
i1, so from 10 surfaces on they readre *l.Scripts: delta_output_format_scripts.zip, run
./run_tests.sh DEV/bin/rdcon PR/bin/rdcon $GPECHOME/docs/examples out 8.🤖 Generated with Claude Code