Repository navigation
RDCON, DCON - BUGFIX - Taylor-slot typos in sing_mmat (F 6th order in slot 6, DCON G 3rd order from G''') - #304
Merged
Merged
Conversation
… slot 6, DCON G 3rd order from G''') sing_mmat (rdcon/sing.f, dcon/sing.f) and sing1_mmat (rdcon/sing1.f) wrote the 6th derivative term of Q*Lbar (20*Q'''*Lbar''') into f(:,:,5), overwriting the 5th-order term and leaving the 6th zero, whenever the series order is >= 6 (in RDCON with sing_order_ceiling, the default, that is sing_order + ceil(2 Re alpha)). The K term and stride/sing.F already use slot 6. dcon/sing.f also set the 3rd-order G term from gmats%f2/6 instead of gmats%f3/6 whenever sing_order >= 3. RDCON (sing_mmat, sing1_mmat) and STRIDE use f3. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Oct 13, 2026
StuartBenjamin
marked this pull request as draft
October 13, 2026 07:24
StuartBenjamin
requested review from
matt-pharr
and removed request for
d-burg
October 13, 2026 08:19
StuartBenjamin
marked this pull request as ready for review
October 13, 2026 09:28
matt-pharr
approved these changes
Oct 15, 2026
matt-pharr
left a comment
matt-pharr
left a comment
Collaborator
There was a problem hiding this comment.
Good catch, FTR I did confirm that this bug was not present in julia.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two slot typos in the Taylor series that
sing_mmatbuilds at each rational surface:sing.fandsing1.f, DCONsing.f): the 6th-order term was written into slot 5, overwriting the 5th order and leaving the 6th at zero.sing.f):gmats%f2/6instead ofgmats%f3/6, which RDCON and STRIDE use.Who is affected: RDCON whenever the series order is 6 or more. With the default
sing_order_ceiling = tthat includessing_order = 5wherever Re α > 0; the shipped examples use 6 and tearing-physics-suite uses 8. DCON only withsing_order≥ 3 (the default is 2, which is unchanged).Tests
develop 1055d1b vs this branch:
On develop these RDCON shifts are inflated by the Galerkin inconsistency fixed in #303. In a separate build that includes the #303 fix (D3D i-file, mpsi 1024), this fix moves 3/1 Δ′ only from −3.987 to −3.992.
Scripts: sing_order_typo_scripts.zip, run
PY_NC=python3 ./run_tests.sh DEV/bin PR/bin $GPECHOME/docs/examples out.🤖 Generated with Claude Code