Repository navigation
Preserve spline roots near cell endpoints with r8 Cardano exponent - #317
Merged
matt-pharr merged 4 commits intoOct 16, 2026
Merged
matt-pharr merged 4 commits into
matt-pharr merged 4 commits into
Conversation
Preserve bracketed roots near cell endpoints and test against an independent Hermite bisection oracle. Chris&AI
We are not changing the testing setup right before releasing the final minor version of the fortran code (v1.0).
Removed comments regarding cube-root exponent precision.
matt-pharr
approved these changes
Oct 16, 2026
Collaborator
There was a problem hiding this comment.
nice simple one-line change. In reality we should probably have every decimal number represented as _r8 across the code... I did a pass last year at getting most of the ones that were important but clearly there are some remaining.
PS I really wish Claude would stop naming things after people that don't need names. Just saying r4 vs r8 exponent would have told the average reader a lot more :^)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A default-real Cardano exponent can move a bracketed spline root beyond the cell endpoint, so
spline_rootsdrops it before Newton refinement. Preserve r8 precision in the exponent.Fixes #316.
Adds a native regression with an independent Hermite-bisection oracle, root count/position/residual checks, and three amplitude scales. The reproducer fails on upstream master
2938fac9; the fix passes there and on develop3e194677throughmake -C install check-spline-root-endpoint. The physical spline is unchanged. A fresh native PENTRC replay reproduces the old failure and completes repaired FGAR/TGAR/PGAR with finite NetCDF output; registered energy controls pass unchanged. Torque convergence remains separate.Chris&AI