Repository navigation
Keep PENTRC small collision damping positive when precession reverses - #320
Open
krystophny wants to merge 1 commit into
Open
krystophny wants to merge 1 commit into
krystophny wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #319.
Negative electric precession currently gives
nutype="small"a negative Krook width and reverses its dissipative response. Use1.0e-5_r8*abs(energy_we)and correct the two stale mode comments. Exact-zero precession still has zero width.The native
xintgrl_lsoderegression compares both precession signs with the independent analytic integralGamma(7/2)/(i*we-nu). It fails before the fix and passes afterward; the corrected dissipative coefficient agrees within1.838e-11relative error. The imaginary response and conjugate-reflection symmetry are checked as well.Validated against current upstream develop
3c0b8f3b, GNU Fortran 16.1.0, with runtime checks and one OpenMP/BLAS thread:make -C install -j4 test-pentrc-small-width CC=gcc-16 FC=gfortran NETCDFHOME=/opt/homebrew LAPACKHOME=/opt/homebrew/opt/openblas FFLAGS='-O0 -g -fcheck=all'Chris&AI