Repository navigation
ggml-cpu: fix unused type warnings in the mul_mat chunk helpers - #260
Merged
Merged
Conversation
The switch to ggml_cpu_vec_dot left type unused in both helpers, which breaks builds with LLAMA_FATAL_WARNINGS.
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The warning fixes are correct, narrowly scoped, and behavior-preserving.
Review effort: Balanced
Findings: None
What changed in this PR
Fixes fatal unused-variable warnings in CPU matrix multiplication helpers without changing behavior.
Changes:
- Marks the retained
typeparameter as unused. - Removes an unused local
typevariable.
| File | Description |
|---|---|
ggml/src/ggml-cpu/ggml-cpu.c |
Resolves unused-type warnings in mul_mat chunk helpers. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The release build (LLAMA_FATAL_WARNINGS=ON) fails on every CPU target since #206: moving the mul_mat chunk helpers to
ggml_cpu_vec_dot(src0)lefttypeunused in both of them.This marks the parameter in
ggml_compute_forward_mul_mat_one_chunkas unused and drops the dead local inggml_compute_forward_mul_mat_id_one_chunk. No behavior change.Tested: a full macOS build with the release workflow's CMake flags and
-DLLAMA_FATAL_WARNINGS=ONnow passes. Not built on Linux/gcc or Windows here; the release run will cover those.Failing run: https://github.com/PrismML-Eng/llama.cpp/actions/runs/35940025804