Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
In the message list (
table_msgs), the Sender column can overflow badly when the message'sFromheader carries a very long display name without an@in it, e.g.:"DHL /EXPRESS ADMINISTRATIVE GROUP (FYDIBOHF23SPDLT)/CN=RECIPIENTS/CN=B7A707497B564FD-43681" <ssssssss.ddddddd@ffffff.fr>The existing truncation logic in
message/index.html.twigonly wraps/splits the part that contains an@(the address). The display-name part, when longer than 35 characters and without an@, was printed in full, breaking the table layout.Fix
Truncate any non-address segment to 35 characters with an ellipsis (same threshold already used for the rest of the block), consistent with how the message subject column is already truncated elsewhere in this template. The full sender value is still available on hover via the existing
titleattribute.Testing
php bin/console lint:twigpasses on the modified template.