fix(update): make the release notes in the update dialog scrollable - #760
Merged
Merged
Conversation
The notes were cut at 900 characters and 260 dp with no way to scroll, while real release notes are 3-15 KB - most of the text was unreachable on every device. - Only the notes area scrolls (touch swipe, D-pad up/down on TV); title and buttons stay fixed, and the notes give up height first so the buttons stay on screen on short or landscape displays. - D-pad up/down is consumed only while the notes can move in that direction; at the edges the key falls through as before. A held key scrolls without restarting the animation. - A fade on the cut edge shows that the text continues. - The button row wraps on narrow phones instead of squeezing the primary button. - A 20,000-character guard replaces the 900 cut. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0157kRGhEoLXosMFZQUoeHpH
Owner
|
Useful focused improvement: release notes can be scrolled without pushing the action buttons away, and buttons wrap on narrow screens. Reviewed the layout and D-pad handling; scroll-boundary unit tests pass and both Android variants compile. Integrated with current main and preserving your original commits. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The release notes in the app update dialog could not be scrolled — not by swiping on touch devices, not with the D-pad on TV. They were cut at 900 characters and 260 dp, while the actual release notes are 3–15 KB, so most of the text was never reachable. Both places that open the dialog (automatic check on Home, Settings → check for updates) share
AppUpdateModal, so both are fixed.Changes (only
AppUpdateModal.kt+ one unit test)verticalScroll); title and buttons stay fixed. The notes takeweight(1f, fill = false)with the existing 260 dp cap, so on short or landscape screens they give up height first and the buttons stay on screen.FlowRow: on narrow phones (e.g. German labels on a 360 dp screen) it wraps instead of squeezing the primary "Download" button. On TV (760 dp) it stays one row.Not in this PR — happy to do it if you want
The notes are the raw GitHub release body, so
##,**and links show as plain text — now the whole text, including the link lines at the end (and the Obtainium badge<img>from the release template). A light plain-text cleanup (drop heading/emphasis markers, turn[text](url)intotext, drop images) or stopping at the "Downloads"/"Get ARVIO" section would be a small follow-up. I kept it out to keep this PR minimal.Testing
AppUpdateNotesScrollTest(D-pad step, edges, short notes never consume up/down).created by Claude (Anthropic) on behalf of @ReichiMD