Skip to content

Fix Guitar Hero controller tutorial confirm path in V5 - #142

Merged
ProhibitedTV merged 6 commits into
mainfrom
fix/guitar-hero-tutorial-confirm-v5
Sep 6, 2026
Merged

ProhibitedTV merged 6 commits into
mainfrom
fix/guitar-hero-tutorial-confirm-v5

Conversation

@ProhibitedTV

Copy link
Copy Markdown
Owner

Live failure

The live GH1 USING THE GUITAR CONTROLLER card is now recognized correctly, but V4 repeatedly sent virtual L2 for the printed Continue (Green button) prompt. The runtime log shows all three L2 retries were accepted by the controller backend yet the screen never advanced.

V5 fix

  • treat this card as a menu-confirm transaction rather than a gameplay-fret transaction
  • send confirm first (virtual Xbox A -> PS2 Cross in this project), matching the existing menu-navigation path
  • retain L2 only as a bounded fallback if the frame does not change
  • default retry sequence is confirm -> l2 -> confirm
  • expose the actual tutorial action sequence and last action in telemetry
  • keep song gameplay bindings unchanged: L2/L1/R1/R2/Cross remain green/red/yellow/blue/orange
  • activate GuitarHeroV5Profile in the registry

Regression coverage

Adds V5 tests proving Cross/confirm is attempted first, L2 is only a later fallback, custom sequences remain bounded, telemetry reports the actual action used, and registry aliases select V5.

Evidence boundary

This addresses the exact retained live deadlock. The note-lane bindings are intentionally not changed from menu evidence; they still require live highway acceptance independently.

@ProhibitedTV
ProhibitedTV merged commit fcecf53 into main Sep 6, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant