Repository navigation
Fix Guitar Hero controller tutorial confirm path in V5 - #142
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Live failure
The live GH1
USING THE GUITAR CONTROLLERcard is now recognized correctly, but V4 repeatedly sent virtualL2for the printedContinue (Green button)prompt. The runtime log shows all three L2 retries were accepted by the controller backend yet the screen never advanced.V5 fix
confirmfirst (virtual Xbox A -> PS2 Cross in this project), matching the existing menu-navigation pathL2only as a bounded fallback if the frame does not changeconfirm -> l2 -> confirmGuitarHeroV5Profilein the registryRegression coverage
Adds V5 tests proving Cross/confirm is attempted first, L2 is only a later fallback, custom sequences remain bounded, telemetry reports the actual action used, and registry aliases select V5.
Evidence boundary
This addresses the exact retained live deadlock. The note-lane bindings are intentionally not changed from menu evidence; they still require live highway acceptance independently.