Repository navigation
Handle Guitar Hero band-name setup in V6 - #143
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7574a86145
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| band_score = self._band_name_evidence(ctx) | ||
| if band_score >= self.band_name_tutorial_guard_threshold: | ||
| return 0.0 |
There was a problem hiding this comment.
When a filtered NAME YOUR BAND frame scores between the default guard (0.55) and ownership threshold (0.70), this returns zero tutorial evidence without claiming the screen itself. After any 0.75-second band-name transition grace expires, tick() delegates to V2; if the frame has presentation-level motion, V2 waits indefinitely, and otherwise its unrelated boot/menu classifiers may act. Thus the exact partial-evidence case described here can still fail to send Start and recreate the first-run blocker; the guard range should retain input-silent band-name ownership or otherwise route into the bounded Start path.
Useful? React with 👍 / 👎.
1 participant
Live failure
The next retained GH1 run successfully left
USING THE GUITAR CONTROLLER, but stopped on the realNAME YOUR BAND/ save-name card. The console continued reporting controller-tutorial retries even though the screen explicitly saysPRESS START BUTTON TO ACCEPT NAME AND CONTINUE.The cause is a second first-run-card collision:
NAME YOUR BANDhas the same broad pale/green paper, dark headline text, and green action badge that V3's tutorial detector uses. V5 therefore kept tutorial ownership after the visual transition and exhausted itsconfirm -> L2 -> confirmbudget instead of pressing Start.V6 fix
NAME YOUR BANDcard before the inherited tutorial pathNEXTplus adjacent redDELETE, combined with the paper/title topologyStartto accept the default band/save name, matching the instruction printed on the retained live screenGuitarHeroV6Profilein the registry and package aliasRegression coverage
Adds tests proving that a band-name-like card can satisfy the old tutorial detector yet V6 preempts it and sends only Start; Start retries remain bounded; a real tutorial topology without the red DELETE badge still uses V5's corrected Confirm/Cross path; telemetry and registry aliases report V6.
Evidence boundary
This fixes the exact retained first-run blocker shown in the latest live capture. Guitar Hero remains diagnostic until the remaining main-menu -> setlist -> difficulty -> highway -> results lifecycle is proven end to end.