Repository navigation
Recognize live Guitar Hero difficulty poster in V7 - #144
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b244be7ad4
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| # Explicitly revoke title ownership from V4's broad title-card guard. The | ||
| # runtime will set MENU/difficulty ownership on the same tick. | ||
| self._title_splash_active = False | ||
| return GuitarHeroScreen.DIFFICULTY |
There was a problem hiding this comment.
Ignore legacy row selection when the poster detector owns the screen
When the dedicated poster detector claims a non-Easy difficulty screen, this returns DIFFICULTY while retaining obs.selected_difficulty_index from the legacy white/yellow row detector. Valid poster colors in the new orange range (HSV hue 18–30) also satisfy that detector's yellow mask, so the large poster background can produce a bogus fallback row—typically index 2—and _tick_non_gameplay then navigates relative to that value instead of the documented fresh Easy selection. Medium, Hard, or Expert configurations can consequently confirm Easy or Medium; poster ownership should suppress the legacy selected-row evidence and use the known initial selection (or add poster-specific selection detection).
Useful? React with 👍 / 👎.
Live failure
The V6 run now clears
NAME YOUR BAND, the controller tutorial, the title screen, Quick Play, and the setlist. It then reaches the real GH1 difficulty screen shown in the retained capture, but the runtime falls back tobounded boot Start probeinstead of selecting a difficulty.The cause is that the actual Quick Play difficulty screen is not the conventional four-row white/yellow menu assumed by V2's generic detector. It is an orange/brown band poster with large black silhouettes, white
DIFFICULTY / EASY / MEDIUM / HARD / EXPERTlettering, and greenCONTINUE+ redBACKfooter badges. The setlist transition temporarily moves the phase to PRESENTATION; once the static poster arrives, generic difficulty evidence remains too weak, so the unknown-static fallback is allowed to probe Start.V7 fix
easy/medium/hard/expertbehavior stays unchangedGuitarHeroV7Profilein the registry and public aliasRegression coverage
Adds synthetic retained-topology tests showing that V7:
NAME YOUR BANDdetectorEvidence boundary
This fixes the exact retained blocker in the latest live run. Guitar Hero remains diagnostic until difficulty -> note highway -> post-song/results is proven end to end.