Repository navigation
ci: pick up the Rust toolchain action's input-handling security fix - #6
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
dtolnay/rust-toolchainmoves from89b12181fb390509a0842a86cc55eeb8eb928c1dto686976e191b89faba57d3206551f0f330d8cb249, the current head of itsstablebranch, in every place it is used:.github/workflows/ci.yml: 4 steps (lint, MSRV, release-profile build, dependency tree count).github/workflows/release.yml: 1 step (release build matrix)The new commit includes upstream PR dtolnay/rust-toolchain#187, "Safely handle action inputs": the
toolchain,targetsandcomponentsinputs now reachrustupthrough environment variables and bash arrays instead of being interpolated into the script text, and the parsed toolchain is written to$GITHUB_OUTPUTwith a heredoc delimiter. Before this, an input value could inject shell commands into the step.The release.yml change is a pin bump only and adopts nothing else from the templates.
Other pins
Every other action pin was checked against its latest release, and each pinned SHA matches the release tag:
No Dependabot github-actions group PR was open, so this PR does the bump itself.
Verification
gh api repos/dtolnay/rust-toolchain/branches/stablereturns686976e1, and the compare against the old pin lists the #187 commits.components: clippy, rustfmt,toolchain: <msrv>,targets: <matrix target>) still split correctly under the new comma-and-whitespace parsing.