Repository navigation
fix(auth): keep the GitLab sign-in callback on the registered port 9876 - #38
Merged
Merged
Conversation
GitLab only accepts the exact redirect URI registered with the application, so falling back to ports 9877 to 9886 made sign-in fail whenever 9876 was busy. OAuthFlow now uses port 9876 only and reports a busy port before the browser opens. Also: - docs: GITSPACE_TOKEN_MASTER_PASSWORD only applies when the keyring is unavailable; the Preferences proxy covers git traffic and repository search, not token checks or OAuth sign-in. - ci: run the built binary with --version and drop the root tests/ directory, which the repository layout does not allow. - dependabot: ignore egui and eframe until the iced port replaces them, since their majors cannot land alone.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #34 with the review findings on it.
OAuthFlownow uses port 9876 only and reports a busy port before the browser opens. README Privacy, SECURITY.md and docs/internals/architecture.md now say port 9876.GITSPACE_TOKEN_MASTER_PASSWORDis only read on the local-key path (load_or_create_local_key), when the keyring is unavailable. The env table now says so, matching the README Privacy row.tests/directory is gone; CI runs the built binary with--versionon all three OS, as the release smoke test does.