Skip to content

fix(annotator): cannot submit after label update #512

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ElodieENSTA merged 1 commit into from
Oct 1, 2026
Merged

fix(annotator): cannot submit after label update #512

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions frontend/src/features/Annotator/Annotation/hooks.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,11 +84,13 @@ export const useAddAnnotation = () => {
}

export const useValidateAnnotation = () => {
const { user } = useLoaderData({ from: '/_authenticated' })
const allAnnotations = useAppSelector(selectAllAnnotations);
const _updateValidation = useUpdateValidation()
const dispatch = useAppDispatch();

return useCallback((annotation: Annotation): Annotation => {
if (annotation.annotator === user.id) return annotation
annotation = dispatch(updateAnnotation({
id: annotation.id,
validation: _updateValidation(true, annotation.validation),
Expand All @@ -109,15 +111,17 @@ export const useValidateAnnotation = () => {
}
dispatch(focusAnnotation(annotation))
return annotation
}, [ dispatch, allAnnotations, _updateValidation ])
}, [ dispatch, allAnnotations, user, _updateValidation ])
}

export const useInvalidateAnnotation = () => {
const { user } = useLoaderData({ from: '/_authenticated' })
const allAnnotations = useAppSelector(selectAllAnnotations);
const _updateValidation = useUpdateValidation()
const dispatch = useAppDispatch();

return useCallback((annotation: Annotation): Annotation => {
if (annotation.annotator === user.id) return annotation
annotation = dispatch(updateAnnotation({
id: annotation.id,
validation: _updateValidation(false, annotation.validation),
Expand All @@ -135,7 +139,7 @@ export const useInvalidateAnnotation = () => {
dispatch(focusAnnotation(annotation))
}
return annotation
}, [ dispatch, allAnnotations, _updateValidation ])
}, [ dispatch, allAnnotations, user, _updateValidation ])
}

export const useUpdateAnnotation = () => {
Expand Down
Loading