Retarget streamed humanoid motion and move to Flutter Scene 0.23 - #1
Merged
Merged
Conversation
The adapter moved to flutter_scene 0.23.0, but the viewer example still pinned 0.19.0, so the example could not resolve its packages. With the example on 0.23.0 it analyses cleanly and its test passes (checked against a local 0.23.0 source; its pubspec.lock needs a networked `flutter pub get` to refresh).
The dart job analyses the repository root before any Flutter package is resolved, so the Flutter Scene viewer example and the Flutter Scene adapter failed with unresolved Flutter imports; every run on main has failed this way since at least July. Both have their own flutter job that resolves and analyses them. The root analysis now excludes them.
The Flutter Scene adapter declares build/shaderbundles/vrm_materials.shaderbundle, which its build hook writes. CI analysed before anything was built, so analysis warned that the asset does not exist and the job failed (on main since the asset was added in July), and the matrix then cancelled the viewer example. Testing runs the hooks first; analysis follows.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on
docs-agent-guides-publish(the agent-guide split); merge after it.What the Kokage app needs from flvtterm for live motion and generated avatars:
dart analyzeno longer scans the two Flutter sub-projects, which it cannot resolve (their own flutter jobs check them), and those jobs now test before analysing, because testing runs the build hook that writes the adapter's declaredbuild/shaderbundlesasset.Checked
Root:
dart format --output=none --set-exit-if-changed .,dart analyze --fatal-infos(no issues),dart test(384 passed);example/runtime_consoleanalyse and run.packages/vrm_flutter_scene(46 tests) andexample/flutter_scene_viewer(1 test) analyse cleanly and pass against a local flutter_scene 0.23.0 source (the Kokage app's vendored copy, used only for this check). The Kokage app's 3,624 tests ran against this tree through its../flvttermpath dependency.Not done
example/flutter_scene_viewer/pubspec.lockstill lists flutter_scene 0.19.0: refreshing it needs a networkedflutter pub get, which was not run. CI resolves it on its own.