fix(k8s): remove plaintext backend Secret; wire External Secrets - #624
Open
woahwhattheheck wants to merge 5 commits into
Open
woahwhattheheck wants to merge 5 commits into
woahwhattheheck wants to merge 5 commits into
Conversation
Stop applying CHANGE_ME credentials from git. Base now uses SecretStore + ExternalSecret against AWS Secrets Manager so missing provider config fails closed. Keep an examples/ reference for local kubectl create flows.
GitHub Actions does not accept retention-days as a workflow root key. That made every push parse-fail with zero jobs. Artifact retention stays on upload-artifact steps; repo retention stays in Settings.
GitHub rejects retention-days on the workflow root (Unexpected value), so checks completed with 0 jobs. Keep artifact-level retention only.
GitHub Actions rejects retention-days at the workflow root, so these runs failed before any job started. Artifact retention stays on upload-artifact; repo run retention is a settings toggle.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #560
Removes the committed
CHANGE_MEKubernetes Secret fromk8s/base/and applies secrets through External Secrets Operator instead (secret-store.yaml+external-secret.yaml→ AWS Secrets Manager). Missing provider/config leaves the ExternalSecret unready, so workloads that needpayd-backend-secretsfail closed.An examples-only manifest remains under
k8s/examples/for localkubectl create secretflows. Deployment and k8s README updated to match.Verify:
k8s/base/has no Secret with stringData credentials; kustomization lists the ESO resources; docs describe the fail-closed path.