feat(revenue_split): emit DistributionExecuted event on distribute - #636
Open
woahwhattheheck wants to merge 3 commits into
Open
woahwhattheheck wants to merge 3 commits into
woahwhattheheck wants to merge 3 commits into
Conversation
Add a structured DistributionExecutedEvent with asset, total_amount, recipient_count, and split_percentages (basis points) so off-chain indexers can track revenue distributions. Replace the ad-hoc Symbol publish. Tests cover emission and one-event-per-asset. Closes Protocol-Guild#515
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #515.
The
revenue_splitcontract performed distributions without a structured event that off-chain indexers and the dashboard could consume. This PR addsDistributionExecutedEventand emits it once per asset insidedistribute.Event fields
asset— token being distributedtotal_amount— amount distributed for that assetrecipient_count— number of recipients in the active splitsplit_percentages— share weights in basis points (10000= 100%)Replaces the prior ad-hoc
("distribute", token) -> amountpublish so the payload matches the structured#[contractevent]pattern used bybulk_payment.Acceptance criteria
test_distribute_emits_distribution_executed_event,test_distribute_emits_one_event_per_asset)distribution_executed_event, map payload)Tests
11 passed (including 2 new event tests).
Tip
KEEP