Avoid refocusing an already-focused Rooster editor on click - #538
Open
squarepots wants to merge 1 commit into
Open
Avoid refocusing an already-focused Rooster editor on click#538squarepots wants to merge 1 commit into
squarepots wants to merge 1 commit into
Conversation
squarepots
force-pushed
the
fix/rooster-editor-click-refocus
branch
from
September 7, 2026 15:15
61529da to
14190c0
Compare
mmso
force-pushed
the
main
branch
10 times, most recently
from
September 11, 2026 16:16
5eb5e79 to
28d81d1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Guard the Rooster wrapper click handler with
editor.hasFocus()soeditor.focus()runs only when the editor is not focused. PreserveonFocusfor every wrapper click.Add contract tests covering focused and unfocused editor states.
Verification
Focused red/green GitHub Actions run:
git diff --checkpasses.Fixes #537