Repository navigation
fixed: point pkg-config to correct include directory - #754
Open
ungeskriptet wants to merge 1 commit into
Open
ungeskriptet wants to merge 1 commit into
ungeskriptet wants to merge 1 commit into
Conversation
When building libcec using nix it occurs that the include directory for pkg-config is being set wrong. Fix it by using CMAKE_INSTALL_INCLUDEDIR. Signed-off-by: David Wronek <david.wronek@mainlining.org>
|
Thank you for the contribution. Before we can merge it we ask that you accept the Pulse-Eight contributor agreement, which grants us the rights we need to ship your work under every licence libCEC is offered under. I have signed the Pulse-Eight contributor agreement and sent it by email You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot. |
Author
|
I have signed the agreement, but there seem to be issues with the pulse-eight.com e-mail server: I tried sending the e-mail from my own mailserver as well as from Gmail. |
Member
|
Looking into it!
From: David Wronek ***@***.***>
Sent: 05 October 2026 11:53
To: Pulse-Eight/libcec ***@***.***>
Cc: Subscribed ***@***.***>
Subject: Re: [Pulse-Eight/libcec] fixed: point pkg-config to correct include directory (PR #754)
[https://avatars.githubusercontent.com/u/40729975?s=20&v=4]ungeskriptet left a comment (Pulse-Eight/libcec#754)<#754 (comment)>
I have signed the agreement, but there seem to be issues with the pulse-eight.com e-mail server:
Your message could not be delivered to the following recipients:
***@***.******@***.***>> (host 'mx1-uk.mtaroutes.com' rejected command 'RCPT ***@***.******@***.***>> NOTIFY=DELAY,FAILURE' with code 550 (5.1.1) 'User unknown')
I tried sending the e-mail from my own mailserver as well as from Gmail.
—
Reply to this email directly, view it on GitHub<#754?email_source=notifications&email_token=AAEFI56GL2YW6IF5VBQX2SL5SN4PPA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTKOJZGI4TSMZTGE4KM4TFMFZW63VKON2WE43DOJUWEZLEUVSXMZLOOSWGM33PORSXEX3DNRUWG2Y#issuecomment-5992993318>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AAEFI52DUSVEFXUW6Y6FWWD5SN4PPAVCNFSNUABEKJSXA33TNF2G64TZHMYTMMJYGQZDSNR3JFZXG5LFHM2TOMJQGQ2TCNJRGKQXMAQ>.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS<https://github.com/notifications/mobile/ios/AAEFI5Y743W2G3GT4XDKPO35SN4PPA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTKOJZGI4TSMZTGE4KM4TFMFZW63VKON2WE43DOJUWEZLEUVSXMZLOOSVGM33PORSXEX3JN5ZQ> and Android<https://github.com/notifications/mobile/android/AAEFI5ZBN6X5SOQ26CWB72D5SN4PPA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTKOJZGI4TSMZTGE4KM4TFMFZW63VKON2WE43DOJUWEZLEUVSXMZLOOSXGM33PORSXEX3BNZSHE33JMQ>. Download it today!
You are receiving this because you are subscribed to this thread.Message ID: ***@***.******@***.***>>
|
Member
|
Could you email it again, we’ve fixed the mailbox issue but lost your email
From: David Wronek ***@***.***>
Sent: 05 October 2026 11:53
To: Pulse-Eight/libcec ***@***.***>
Cc: Subscribed ***@***.***>
Subject: Re: [Pulse-Eight/libcec] fixed: point pkg-config to correct include directory (PR #754)
[https://avatars.githubusercontent.com/u/40729975?s=20&v=4]ungeskriptet left a comment (Pulse-Eight/libcec#754)<#754 (comment)>
I have signed the agreement, but there seem to be issues with the pulse-eight.com e-mail server:
Your message could not be delivered to the following recipients:
***@***.******@***.***>> (host 'mx1-uk.mtaroutes.com' rejected command 'RCPT ***@***.******@***.***>> NOTIFY=DELAY,FAILURE' with code 550 (5.1.1) 'User unknown')
I tried sending the e-mail from my own mailserver as well as from Gmail.
—
Reply to this email directly, view it on GitHub<#754?email_source=notifications&email_token=AAEFI56GL2YW6IF5VBQX2SL5SN4PPA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTKOJZGI4TSMZTGE4KM4TFMFZW63VKON2WE43DOJUWEZLEUVSXMZLOOSWGM33PORSXEX3DNRUWG2Y#issuecomment-5992993318>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AAEFI52DUSVEFXUW6Y6FWWD5SN4PPAVCNFSNUABEKJSXA33TNF2G64TZHMYTMMJYGQZDSNR3JFZXG5LFHM2TOMJQGQ2TCNJRGKQXMAQ>.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS<https://github.com/notifications/mobile/ios/AAEFI5Y743W2G3GT4XDKPO35SN4PPA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTKOJZGI4TSMZTGE4KM4TFMFZW63VKON2WE43DOJUWEZLEUVSXMZLOOSVGM33PORSXEX3JN5ZQ> and Android<https://github.com/notifications/mobile/android/AAEFI5ZBN6X5SOQ26CWB72D5SN4PPA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTKOJZGI4TSMZTGE4KM4TFMFZW63VKON2WE43DOJUWEZLEUVSXMZLOOSXGM33PORSXEX3BNZSHE33JMQ>. Download it today!
You are receiving this because you are subscribed to this thread.Message ID: ***@***.******@***.***>>
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When building libcec using nix it occurs that the include directory for pkg-config is being set wrong. Fix it by using CMAKE_INSTALL_INCLUDEDIR.