Repository navigation
feat: interactive check-pinned, review past pins - #89
Merged
Merged
Conversation
Since 0c36d0f the whole body of _run_plann_tests sat one level too deep, after the `return ret` of the nested dag() helper, so test_plann only started and stopped xandikos and asserted nothing. Dedented; it passes again. Prompt: So yesterday and today I've had a calendar with tasks "pinned" to the calendar through events. Did I make any `interactive`-command for going through those events and answering y/n on whether the tasks were done or not? Followup-Prompt: Yes, I need that. [an interactive command to go through past pinning events and ask whether each task was done] Followup-Prompt: go for it, including fixing the dead functional test. Assisted-By: Claude Opus 5.5 <noreply@anthropic.com> Reviewed-by: Tobias Brox <tobias@redpill-linpro.com>
Goes through last week's events pinning a task to the calendar and asks if the task was done. Yes completes the task (with subtasks), confirms the event and offers to cancel its other pins; no cancels the event; partially runs the split flow. Confirmed events are not asked about again, which matters for recurring tasks. It runs first in manage-tasks, replacing the TODO there. The test server's event loop is now closed on stop, so two functional tests can run in one session. Prompt: So yesterday and today I've had a calendar with tasks "pinned" to the calendar through events. Did I make any `interactive`-command for going through those events and answering y/n on whether the tasks were done or not? Followup-Prompt: Yes, I need that. [an interactive command to go through past pinning events and ask whether each task was done] Followup-Prompt: go for it, including fixing the dead functional test. Followup-Prompt: Fix the commit, I'll push manually [add the PR link to the CHANGELOG entry, and fix the typo in the recorded prompt as in the first commit] Assisted-By: Claude Opus 5.5 <noreply@anthropic.com>
tobixen
force-pushed
the
feat/check-pinned
branch
from
November 12, 2026 07:17
c6d19e7 to
1e949ea
Compare
Other pins of a completed task are only offered for cancelling when they pin no other open task, and before the event is confirmed, so a failed save no longer leaves them behind. A task closed through the edit prompt now confirms (or cancels) its event. A task or event deleted on the server meanwhile no longer stops the run. Tests cover recurring tasks and a successful partial split. Prompt: [fix issues found during the review process] Assisted-By: Claude Opus 5.5 <noreply@anthropic.com> Reviewed-by: Tobias Brox <tobias@redpill-linpro.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit message:
Also piggy-backing:
test: revive the body of the functional test- since 0c36d0f the body oftest_plannsat after areturnin a nested helper, so it asserted nothing.🤖 Generated with Claude Code