Repository navigation
chore(docker): remove unused MinIO and mc services - #250
Merged
Merged
Conversation
MinIO was never wired into Django: dev settings use FileSystemStorage and production uses AWS S3 directly, with no S3 endpoint override anywhere in the history. The MinIO images are also no longer pullable (quay.io returns 401, Docker Hub removed minio/minio and minio/mc), which broke `task stack:pull`, the README setup step and `docker compose run web` on a fresh machine because web depended on minio. Drop the minio and mc services, the minio-data volume, the web dependency, and the related references in Taskfile, README, CLAUDE.md and .gitignore.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove the
minioandmcservices from the local Docker stack, together with every reference to them.Why
FileSystemStorage(base.py, not overridden indev.py), and no settings file, env file or commit in the history ever configured an S3 endpoint (git log --all -S endpoint_urlis empty). CI does not use it either. Production uses AWS S3 directly throughS3Boto3Storageinproduction.py, so it is unaffected.quay.io/minio/minioandquay.io/minio/mcnow return401 Unauthorized, and Docker Hub no longer servesminio/minio/minio/mc(the upstream repo is archived). As a result,task stack:pull, the README setup step (docker compose up -d postgres redis minio) anddocker compose run web(which depended onminio) fail on any machine without a cached image.A replacement (RustFS 1.0.0) was evaluated and works with django-storages/boto3/Wagtail, but since nothing needs local S3 today, no replacement is added.
Changes
docker-compose.yml: drop theminioandmcservices, theminio-datavolume and theweb -> miniodependencyTaskfile.yaml:stack:pullonly pullspostgresandredisREADME.md,CLAUDE.md: update the service lists.gitignore: drop themc/entryDevelopers can remove a leftover local volume with
docker volume rm <project>_minio-data.Overlaps with the MinIO part of draft #202; that PR will need a small rebase on
docker-compose.yml.Test plan
docker compose config -qpasses, services:postgres,redis,test,webdocker compose run --rm test: 7 tests OKminio/mcreference in tracked files🤖 Generated with Claude Code