Repository navigation
Fix Misra-Gries edge coloring for UnGraphMap - #1707
Open
mikegit123git wants to merge 1 commit into
Open
mikegit123git wants to merge 1 commit into
mikegit123git wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1593.
Fix a panic in
misra_gries_edge_color()when used with Petgraph'sUnGraphMap.Undirected GraphMap adjacency iterators may return edge references with a reversed orientation relative to their canonical stored edge IDs. Direct edge index lookup can therefore panic with
edge not found.Changes
Regression Tests
Added coverage for:
Validation
All local checks passed:
cargo test -p rustworkx-core: 536 tests passed.cargo fmt --all -- --check: passed.cargo clippy -p rustworkx-core --all-targets -- -D warnings: passed.git diff --check: passed.