Repository navigation
feat(variables): add JSON external secret UI - #3093
Draft
TheoGrandin74 wants to merge 16 commits into
Draft
TheoGrandin74 wants to merge 16 commits into
TheoGrandin74 wants to merge 16 commits into
Conversation
|
View your CI Pipeline Execution ↗ for commit 5b007ba
💡 Verify your cache is correct by running tasks in a sandbox. Read docs ↗ ☁️ Nx Cloud last updated this comment at |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## staging #3093 +/- ##
===========================================
- Coverage 52.48% 52.02% -0.47%
===========================================
Files 744 1339 +595
Lines 18789 29827 +11038
Branches 5731 8974 +3243
===========================================
+ Hits 9862 15518 +5656
- Misses 7357 11803 +4446
- Partials 1570 2506 +936
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a JSON external-secret option to the variables page and service-creation flow. Users select a secret-manager source and reference, assign a display name, and optionally add a key prefix and description. JSON contents are not fetched or displayed in the console.
Draft / integration status
The JSON API contract is still pending. Add, Edit, and Delete work locally for user-entered JSON references. Variables-page drafts reset on remount; creation-flow drafts stay in form state but are not persisted during service creation. TODO comments mark the real API handler integration points. No seeded example data or injected references remain. JSON references are never sent through the single-variable API.
Before shipping: replace local JSON handlers with API persistence and validation, integrate JSON creation during service creation, and finish JSON analytics. This PR does not change deployment behavior.
Validation