Repository navigation
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…edCluster Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… strings Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…er cluster hooks Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…er cluster utils Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…naged creation flow Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…dren Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…heir own library Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ng props Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…fault value Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
View your CI Pipeline Execution ↗ for commit 1de6f66
💡 Verify your cache is correct by running tasks in a sandbox. Read docs ↗ ☁️ Nx Cloud last updated this comment at |
There was a problem hiding this comment.
1 issue found across 52 files
Confidence score: 4/5
- In
profile-array-item-modal.tsx, an empty required field can still fail validation when disabled, blocking Save even though the user cannot edit it. Skip validation for disabled fields or ensure they have a value.
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="libs/domains/clusters/feature/src/lib/cluster-profile/profile-array-item-modal.tsx">
<violation number="1" location="libs/domains/clusters/feature/src/lib/cluster-profile/profile-array-item-modal.tsx:94">
P3: A read-only (disabled) field bypasses the user but still runs the `validate` rule: if such a field is `required` and its value is empty, the modal shows "Please enter a value." and blocks Save with no way to fill the field in. Consider skipping the fulfilled/required check for disabled fields (read-only values are API-supplied), or masking the error when `field.readOnly` is set.</violation>
</file>
Reply with feedback, questions, or to request a fix.
View guided diff | Turn on auto-fix | Re-trigger cubic
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## feat/cluster-engine-v2 #3099 +/- ##
==========================================================
+ Coverage 52.12% 52.36% +0.24%
==========================================================
Files 1412 1377 -35
Lines 31720 30690 -1030
Branches 9414 9228 -186
==========================================================
- Hits 16534 16072 -462
+ Misses 12579 12085 -494
+ Partials 2607 2533 -74
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
…orAttached Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
There was a problem hiding this comment.
All reported issues were addressed across 2 files (changes from recent commits).
Reply with feedback, questions, or to request a fix.
View guided diff | Turn on auto-fix | Re-trigger cubic
- Remove the cluster header and its unused context data - Add a divider to the profile sidebar
- Detect when the selected component matches only hidden settings - Cover the filtered settings empty state
There was a problem hiding this comment.
All reported issues were addressed across 3 files (changes from recent commits).
Reply with feedback, questions, or to request a fix.
View guided diff | Turn on auto-fix | Re-trigger cubic
- Add hover and pointer styling only when the status panel can open - Cover clickable and unavailable status states in the footer spec
- Allow saving while configuration edits are being checked again - Keep saving blocked when checks fail or report violations or missing inputs
… the search Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
There was a problem hiding this comment.
1 issue found across 3 files (changes from recent commits).
Confidence score: 5/5
profile-changes-bar.tsxretains the last verdict while edits are rechecked, so a previous failure can keep submission disabled until the new result arrives.
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="libs/domains/clusters/feature/src/lib/cluster-profile/profile-changes-bar.tsx">
<violation number="1" location="libs/domains/clusters/feature/src/lib/cluster-profile/profile-changes-bar.tsx:9">
P3: This says `canSubmit` is true during every recheck, but a previous failed verdict remains false until the new result arrives. Describe that the last verdict is retained while edits are checked again.</violation>
</file>
Reply with feedback, questions, or to request a fix.
View guided diff | Turn on auto-fix | Re-trigger cubic
| isSaving: boolean | ||
| isDeploying: boolean | ||
| // False while the edits are being checked or do not pass the checks shown in the form. | ||
| // False once a check fails or reports violations or missing inputs; true while the edits are being checked. |
There was a problem hiding this comment.
P3: This says canSubmit is true during every recheck, but a previous failed verdict remains false until the new result arrives. Describe that the last verdict is retained while edits are checked again.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. At libs/domains/clusters/feature/src/lib/cluster-profile/profile-changes-bar.tsx, line 9:
<comment>This says `canSubmit` is true during every recheck, but a previous failed verdict remains false until the new result arrives. Describe that the last verdict is retained while edits are checked again.</comment>
<file context>
@@ -6,7 +6,7 @@ interface ProfileChangesBarProps {
isSaving: boolean
isDeploying: boolean
- // False while the edits are being checked or do not pass the checks shown in the form.
+ // False once a check fails or reports violations or missing inputs; true while the edits are being checked.
canSubmit: boolean
onReset: () => void
</file context>
| // False once a check fails or reports violations or missing inputs; true while the edits are being checked. | |
| // False after a check fails or reports violations or missing inputs; the last verdict is retained while edits are checked again. |
Addresses @RemiBonnet's review of #2997, with one commit per comment (a few closely related comments share a commit).
Fixes
readOnlyfields disabled.useBlockerpattern inClusterAdd.Moves and renames
isHttpStatusmoved to@qovery/shared/utils, next to the Axios interceptor, and gained a spec.useIsEngineV2Clusterrenamed touseIsOperatorAttached.clusters/feature/src/lib/hooks/<hook>/, andplatform-configuration-utilsmoved toclusters/feature/src/lib/utils/.'', as Remi suggested.index.tsexport is nowexport * from './lib/cluster-profile/profile-tree'.@qovery/domains/catalog/feature(libs/domains/catalog/feature). It holdscatalog-variable-field(moved out ofshared/util-js) andCatalogVariableInput(moved out ofconsole-shared).Self-managed creation flow
HeadingandSection.StepLayoutandStepSectionare typed withPropsWithChildren.Calloutthat keepsrole="alert"; a test covers it.Shared UI
EmptyState: size and color variants now usecva. Snapshot changes are class order only.HighlightText: new stories for a match, no match, and repeated matches.Tooltip: dropped the unusedclassNameArrowandcollisionPaddingprops.InputSearch: thedefaultValueprop and itsuseEffectsync are replaced by an optional controlledvalue. The profile sidebar now owns the input state. It updates that state when the URL search changes, using React's adjust-state-on-prop-change pattern rather than an effect.InputSelectSmallariaLabel,ariaDescribedBy,ariaInvalid. Its visible label isn't linked to the<select>, so it previously had no accessible name.InputTextSmallid.InputToggleariaDescribedBy,ariaInvalid.top-1/2. It looks the same at the default height and is needed for theh-10catalog select.Testing
tscon the console app passes at every commit.