Skip to content

feat(qov-2386): Enable editing wide cluster credentials under feature flag - #3102

Open
mzottola wants to merge 4 commits into
stagingfrom
qov-2386-wide-credentials-cluster
Open

mzottola wants to merge 4 commits into
stagingfrom
qov-2386-wide-credentials-cluster

Conversation

@mzottola

@mzottola mzottola commented Oct 13, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Issue: QOV-2386
The current view is on a feature flag, restricted at the moment for our sandbox organization
For the moment, only the edition is supported (will do the creation flow in a future PR).

Screenshots / Recordings

  • Add a toggle to enable restriction permissions, toggle disabled:
image
  • toggle enabled:
image

Testing

  • Changes tested locally in the relevant Console's pages and Storybooks
  • yarn test or yarn test -u (if you need to regenerate snapshots)
  • yarn format
  • yarn lint

PR Checklist

  • I followed naming, styling, and TypeScript rules (see .cursor/rules)
  • I performed a self-review (diff inspected, dead code removed)
  • I titled the PR using Conventional Commits with a scope when possible (e.g. feat(service): add new Terraform service) - required for semantic-release
  • I only kept necessary comments, written in English (watch for useless AI comments)
  • I involved a designer to validate UI changes if I am not a designer
  • I covered new business logic with tests (unit)
  • I confirmed CI is green (Codecov red can be accepted)
  • I reviewed and executed locally any AI-assisted code

Summary by cubic

Enables wide cluster credentials for EKS managed clusters under the wide-credentials feature flag, letting users separate restrictive credentials from extended AWS role credentials without forcing a redeploy.

  • Adds a "Use restrictive permissions" toggle in the cluster credentials settings; extended credentials are shown and required only when restrictive permissions are on, and only AWS role credentials (STS) can be selected.
  • Only a change to the restrictive credentials triggers a cluster redeploy; saving the toggle or extended credentials does not, so useEditCluster gained silently and showClusterUpdateAction options and seeds the edited cluster into the cache before the refetch completes.
  • Bumps qovery-typescript-axios to include wide_permission_credentials support.

Written for commit 516a344. Summary will update on new commits.

View guided diff Turn on auto-fix

@nx-cloud

nx-cloud Bot commented Oct 13, 2026 •

Copy link
Copy Markdown

View your CI Pipeline Execution ↗ for commit 93734db

Command Status Duration Result
nx run console:build --parallel=3 --configurati... ✅ Succeeded 52s View ↗
nx affected --target=test --parallel=3 --config... ✅ Succeeded 2m 56s View ↗
nx affected --target=lint --parallel=3 ✅ Succeeded 2m 10s View ↗
nx-cloud record -- yarn nx format:check ✅ Succeeded 2s View ↗

💡 Verify your cache is correct by running tasks in a sandbox. Read docs ↗


☁️ Nx Cloud last updated this comment at 2026-10-13 16:26:05 UTC

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 12 files

Reply with feedback, questions, or to request a fix.

View guided diff | Turn on auto-fix | Re-trigger cubic

@codecov

codecov Bot commented Oct 13, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 90.90909% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 53.84%. Comparing base (ac7c13b) to head (93734db).

Files with missing lines Patch % Lines
...src/lib/hooks/use-edit-cluster/use-edit-cluster.ts 81.25% 1 Missing and 2 partials ⚠️
...er-credentials-modal/cluster-credentials-modal.tsx 50.00% 0 Missing and 1 partial ⚠️
...r-credentials-settings/save-cluster-credentials.ts 94.44% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           staging    #3102      +/-   ##
===========================================
+ Coverage    52.40%   53.84%   +1.44%     
===========================================
  Files         1296      899     -397     
  Lines        28962    23033    -5929     
  Branches      8782     7163    -1619     
===========================================
- Hits         15177    12402    -2775     
+ Misses       11368     8622    -2746     
+ Partials      2417     2009     -408     
Flag Coverage Δ
unittests 53.84% <90.90%> (+1.44%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 3 files (changes from recent commits).

Reply with feedback, questions, or to request a fix.

View guided diff | Turn on auto-fix | Re-trigger cubic

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="libs/domains/clusters/feature/src/lib/hooks/use-edit-cluster/use-edit-cluster.spec.tsx">

<violation number="1" location="libs/domains/clusters/feature/src/lib/hooks/use-edit-cluster/use-edit-cluster.spec.tsx:90">
P3: `mutate` starts an asynchronous request, but this synchronous test clears the QueryClient before it settles, allowing mutation and query updates after the test exits. Await `mutateAsync` inside an async `act` before inspecting and clearing the client.</violation>
</file>

@mzottola
mzottola force-pushed the qov-2386-wide-credentials-cluster branch from 706cff2 to 516a344 Compare October 13, 2026 15:11
@mzottola mzottola changed the title feat(qov-2386): Enable wide cluster credentials under feature flag feat(qov-2386): Enable editing wide cluster credentials under feature flag Oct 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants