Repository navigation
Conversation
|
View your CI Pipeline Execution ↗ for commit 93734db
💡 Verify your cache is correct by running tasks in a sandbox. Read docs ↗ ☁️ Nx Cloud last updated this comment at |
There was a problem hiding this comment.
All reported issues were addressed across 12 files
Reply with feedback, questions, or to request a fix.
View guided diff | Turn on auto-fix | Re-trigger cubic
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## staging #3102 +/- ##
===========================================
+ Coverage 52.40% 53.84% +1.44%
===========================================
Files 1296 899 -397
Lines 28962 23033 -5929
Branches 8782 7163 -1619
===========================================
- Hits 15177 12402 -2775
+ Misses 11368 8622 -2746
+ Partials 2417 2009 -408
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
1 issue found across 3 files (changes from recent commits).
Reply with feedback, questions, or to request a fix.
View guided diff | Turn on auto-fix | Re-trigger cubic
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="libs/domains/clusters/feature/src/lib/hooks/use-edit-cluster/use-edit-cluster.spec.tsx">
<violation number="1" location="libs/domains/clusters/feature/src/lib/hooks/use-edit-cluster/use-edit-cluster.spec.tsx:90">
P3: `mutate` starts an asynchronous request, but this synchronous test clears the QueryClient before it settles, allowing mutation and query updates after the test exits. Await `mutateAsync` inside an async `act` before inspecting and clearing the client.</violation>
</file>
706cff2 to
516a344
Compare
Summary
Issue: QOV-2386
The current view is on a feature flag, restricted at the moment for our sandbox organization
For the moment, only the edition is supported (will do the creation flow in a future PR).
Screenshots / Recordings
Testing
yarn testoryarn test -u(if you need to regenerate snapshots)yarn formatyarn lintPR Checklist
.cursor/rules)feat(service): add new Terraform service) - required for semantic-releaseSummary by cubic
Enables wide cluster credentials for EKS managed clusters under the
wide-credentialsfeature flag, letting users separate restrictive credentials from extended AWS role credentials without forcing a redeploy.useEditClustergainedsilentlyandshowClusterUpdateActionoptions and seeds the edited cluster into the cache before the refetch completes.qovery-typescript-axiosto includewide_permission_credentialssupport.Written for commit 516a344. Summary will update on new commits.