Skip to content

fix(download-archive): correctly parse deployment id - #729

Merged
erebe merged 1 commit into
mainfrom
erebe/archive
Oct 7, 2026
Merged

erebe merged 1 commit into
mainfrom
erebe/archive

Conversation

@erebe

@erebe erebe commented Oct 7, 2026 •

Copy link
Copy Markdown
Contributor

Summary by cubic

Fixes execution ID parsing in download-s3-archive so IDs carrying both a deployment id and a Unix timestamp are handled correctly.

  • Previously a timestamp was only stripped from a bare UUID; IDs like <uuid>-<id>-<timestamp> were rejected or truncated incorrectly.
  • The new parser strips only a trailing 10-digit timestamp and keeps shorter numeric suffixes as part of the key.
  • Adds a test suite covering valid and invalid ID shapes.

Written for commit 7914f8b. Summary will update on new commits.

View guided diff Turn on auto-fix

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 2 files

Reply with feedback, questions, or to request a fix.

View guided diff | Turn on auto-fix | Re-trigger cubic

Comment thread pkg/download_s3_archive.go
@erebe
erebe merged commit 15cfa97 into main Oct 7, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants