Repository navigation
Conversation
sphinx-exercise 1.2.2 writes a captioned figure inside an exercise or solution box as [H], so the LaTeX build no longer stops with "Not in outer par mode". This lands before QuantEcon/lecture-python.myst#1121, whose restored captions in solutions reach this repository through the translation sync. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WT8bMZoSvoQTbzkdmZiMnd
✅ Deploy Preview for astonishing-narwhal-a8fc64 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Note
Copilot was unable to complete this review at the selected tier due to model policy or plan restrictions.
🟢 Approval recommended
The change is a straightforward dependency pin update to sphinx-exercise 1.2.2 in environment.yml with no review evidence of unresolved issues or required follow-ups.
No open issues 🎉
What changed in this PR
Upgrades the CI/cache/publish build environment to pick up the sphinx-exercise LaTeX fix that prevents PDF build failures when captioned figures appear inside exercise/solution boxes.
Changes:
- Bump
sphinx-exercisefrom1.2.1to1.2.2inenvironment.yml.
| File | Description |
|---|---|
| environment.yml | Updates the pinned sphinx-exercise version to 1.2.2 for the main build environment used by CI/cache/publish. |
Review effort: Balanced
|
Closing as not needed: this repository builds HTML only (its PDF steps are commented out), and sphinx-exercise 1.2.2 changes only LaTeX output. Dependabot's weekly conda update will bring the pin in step. |
Upgrades sphinx-exercise from 1.2.1 to 1.2.2 in
environment.yml, the file that CI, cache and publish build with.sphinx-exercise 1.2.1 wrote a captioned figure inside an exercise or solution box as a floating
\begin{figure}[htbp], which LaTeX rejects there withNot in outer par mode. 1.2.2 writes it as[H], as Sphinx does inside its own admonitions; see executablebooks/sphinx-exercise#95.Why now: QuantEcon/lecture-python.myst#1121 restores nine figure captions inside solutions, which reach this repository through the translation sync. This repository builds HTML only (the PDF steps in
ci.ymlandpublish.ymlare commented out), so 1.2.1 would not fail on them. This bump keeps the pin in step with the English source, and the two PRs can merge in either order.The release has the same dependencies as 1.2.1, and HTML output is unchanged.
environment-cn.yml(pinned at 1.2.0) is used only by the inactive.github/workflows/_future/ci-cn.yml, so this PR leaves it alone.Part of QuantEcon/workspace-lectures#70.
🤖 Generated with Claude Code
https://claude.ai/code/session_01WT8bMZoSvoQTbzkdmZiMnd