Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 🚀 New features to boost your workflow:
|
Member
|
Would be nice to get CI fixed, but happy to merge and release already if this is very blocking |
lkdvos
approved these changes
Aug 19, 2026
Member
Author
|
Right, forgot about the JLArrays thing. It's just blocking QuantumKitHub/MPSKit.jl#514, which isn't very urgent by itself. So same to me, also fine with waiting for the CI fix. |
Member
Author
|
When do you think you would have some time to look at the CI failures @lkdvos? No hurry, but if it's not for right away I would go ahead and tag this so we can push through the MPSKit fix. |
Member
|
Have them locally fixed, will try and push this today or tomorrow:) |
Member
|
Update: fixed now, will include the indexing performance changes as they include a number of bug fixes as well, and then merge and release this tomorrow |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bump patch version to release fixed for
TensorKit.BraidingTensor.Release notes:
Patch with fixes for
TensorKit.BraidingTensor, avoiding abstract type parameters and adding constructors forSumSpaceinstances.