Repository navigation
Conversation
InputKeyMapServiceClient wrote each binding name straight into the LocalizationTable, plus a pseudo-locale copy, and every raw write re-translates every AutoLocalize label on screen. It now uses the translator's SetEntryValue, which is batched with the other entry writes and only adds the pseudo-locale in Studio.
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
InputKeyMapServiceClientwrote each binding name straight into the LocalizationTable (plus a pseudo-locale copy), and every rawSetEntryValuere-translates every AutoLocalize label on screen, so registering key maps while a UI was up cost about 0.05 ms per label per write. It now goes through the translator'sSetEntryValue, which batches with the other entry writes; like every other translator entry, the pseudo-locale copy is now only written in Studio, and the unused@quenty/pseudolocalizedependency is dropped. Checked in the package's test place:FormatByKey("keybinds.Honk")still returns "Honk".