Repository navigation
Conversation
Promise.isPromise read value.ClassName, which runs the value's __index, so anything handed to Promise code that errors on unknown keys (Cmdr's Registry and Dispatcher, for example) threw instead of being treated as a plain value. It now reads ClassName from the metatable with rawget, which still matches promises from another copy of the package.
This branch had an error being deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Promise.isPromisereadvalue.ClassName, which runs the value's__index, so returning or resolving any table that errors on unknown keys (Cmdr'sRegistryandDispatcherdo, for example) threw "ClassName is not a valid member" from inside Promise code. It now readsClassNameoff the metatable withrawget, which still matches promises from another copy of the package; the one behaviour change is that a bare{ ClassName = "Promise" }table no longer counts, and nothing in the repo relies on that. The spec covers both cases, and all 129 promise specs pass in Studio.