Repository navigation
Conversation
Slow clients no longer get a false "not loaded" warning for every binder when Start comes more than 5 s after Init.
This branch had an error being deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The "Binder %q is not loaded. Call :Start() on it!" warning fired 5 s after
:Init(), but on slow clients:Start()can legitimately come later than that (on a Fire HD 8 with ServiceBag Init/Start spread over frames as in #839, the Starts landed ~8 s after the Inits), so every binder warned even though all of them started. The delay is now 30 s; a genuinely forgotten:Start()is still reported, just later.promiseBoundClass's 5 s infinite-yield warning is left as it is.