Repository navigation
Conversation
Writes to a LocalizationTable under LocalizationService cost milliseconds each (about 7 ms on a Studio client, against 0.006 ms unparented), and a service bag whose Init spans several frames flushes once per frame. TranslatorService now creates its table unparented and parents it on Start, after any flush already queued has landed. Other services in the realm still share it, the last holder destroys a table that was never parented, and a table saved in the place is used where it is.
This branch had an error being deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TranslatorService now creates its LocalizationTable unparented and parents it on Start, after any flush already queued has landed, because each write to a table under LocalizationService costs about 7 ms on a Studio client against 0.006 ms unparented, and a service bag whose Init spans several frames (SetInitFrameBudget, #839) flushes once per frame. In a game with a budgeted client Init this took the 10 flushes before Start from 45.8 ms to 4.2 ms plus one 10.5 ms parent; other services in the realm still share the table, and a table saved in the place is used where it is. The new specs pass in Studio (the 6 failures there are the same Roblox-translator timeouts as on main), and the numbers are written up in docs/engine-behavior.md.