Repository navigation
Fix/get applied versions failure boundary - #2864
Merged
Baskarayelu merged 5 commits intoOct 1, 2026
Merged
Baskarayelu merged 5 commits into
Baskarayelu merged 5 commits into
Conversation
…ppliedVersions getAppliedVersions could surface raw driver errors, reject valid zero versions, silently return duplicates, and hand back unsorted or non-numeric values, so callers could not distinguish an empty ledger from an unreadable one. Introduce MigrationStateReadError with a retryable hint, validate and de-duplicate every row before returning, and cover the boundaries with a dedicated suite. Also correct the v006 backfill_progress version to match its file name. 🤖 Generated with Codebuff Co-Authored-By: Codebuff <noreply@codebuff.com>
Unknown event types were logged and dropped, the queue overflow counter was written inside the transaction it was meant to record (so it rolled back with it), and an unset CSRF header rejected every machine-to-machine request. Reject unknown events, persist the overflow metric after the failed transaction, and require the token only for browser-originated requests. 🤖 Generated with Codebuff Co-Authored-By: Codebuff <noreply@codebuff.com>
Several suites ran against a shared on-disk database whose schema and fixtures they did not own, so they failed with "no such table" or stale connection errors depending on what ran first. Give each suite its own temp database, supply the missing statements and columns, and make the event-processing suite create the directory its database resolves from. 🤖 Generated with Codebuff Co-Authored-By: Codebuff <noreply@codebuff.com>
Contract tests had no schema to validate the health payload or the canonical 404/401 bodies against, and the case extractor missed path parameters declared on the operation rather than the path item. Add the missing schemas and read parameters from both levels so generated examples resolve. 🤖 Generated with Codebuff Co-Authored-By: Codebuff <noreply@codebuff.com>
Contributor
|
This pull request currently has a merge conflict with Could you please resolve the conflict (merge or rebase on the latest |
|
@dunnidev Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2686