Repository navigation
Conversation
Author
|
@GuyZivRH - could you please /ok-to-test and review this? Would appreciate your feedback. Thanks! |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MCPChecker runs were skipping the
analyzephase on the CI pipeline, soaggregate_scorecardnever ran and submissions could not push evaluation facts to Compass viametadata.yamlgate_policy. This PR runsanalyzefor MCPChecker and handlesmcpchecker-report.jsonwithout changing Harbor/ASE/A2A/AEH behavior.Compass push remains opt-in per submission (
gate_policyin each package’smetadata.yaml). No submission metadata is changed in this PR.Changes
ci-pipeline.yaml,ci-pipeline-dev.yaml): removewhenthat skippedanalyzeforeval-engine=mcpchecker.analyze-and-check-degradationtask: add MCPChecker branch (readmcpchecker-report.json, set Tekton results); skip A/Breport.mdregeneration for MCPChecker; guardreport.mdcat when missing.evaluatetask: fix MCPChecker stepwhengates fromharbor/bothtomcpcheckerso eval/aggregate actually run for MCPChecker.Test plan
analyzeruns afterevaluate; scorecard step runs when enabled.gate_policy: no Compass POST from pipeline.ab-eval-flow:oc apply -f pipeline/pipelines/ci-pipeline.yamloc apply -f pipeline/tasks/phases/evaluate.yamloc apply -f pipeline/tasks/post/analyze-and-check-degradation.yamloc get pipeline.tekton.dev/abevalflow-pipeline -n ab-eval-flow -o yaml | grep -A6 "name: analyze"—analyzeshould showrunAfter: ["evaluate"]and should not showoperator: notin.Related
skill-submissions); Compassgate_policyPR planned separately after Compass confirms factRef/UI.