Conversation
Update 27 tests (19 smoke, 8 smoke-limbo) to use replacement flags for specialized kernel generation. The -fopenmp-target-ignore-env-vars flag is being replaced with -fopenmp-assume-teams-oversubscription and -fopenmp-assume-threads-oversubscription to sync with upstream LLVM. The replacement flags provide equivalent functionality for no-loop kernel optimizations by indicating that the runtime can ignore environment variables for thread/team configuration.
no-loop-4 and no-loop-7 were the only tests that combined -fopenmp-target-fast with the negative ignore-env-vars flag, so they are the ones that get the replacement negative variants. The remaining tests only dropped the flag, it did nothing there without target-fast.
nicebert
requested review from
carlobertolli,
estewart08,
gregrodgers,
ronlieb and
zGoldthorpe
as code owners
September 9, 2026 12:05
Base automatically changed from
amd/dev/nicebert/remove-ignore-env-vars-tests
to
aomp-dev
September 14, 2026 12:29
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
no-loop-4 and no-loop-7 were the only tests that combined
-fopenmp-target-fast with the negative ignore-env-vars flag, so they are the
ones that get the replacement negative variants. The remaining tests only
dropped the flag, it did nothing there without target-fast.
Depends on: #2053
Depends on: ROCm/llvm-project#1698