Conversation
Record once that the file defines variables for the scripts that source it, so their uses are invisible to static analysis, and quote the two expansions flagged for word splitting. Neither has an effect. Quoting the array element in shquot also stops an argument holding a tab or a newline from being split into several quoted words. That output is meant to be pasted back into a shell, where the split silently alters the command. AI-assisted.
mhalk
requested review from
carlobertolli,
estewart08,
gregrodgers,
ronlieb and
zGoldthorpe
as code owners
September 23, 2026 10:33
1 task done
Collaborator
Author
|
Here's the corresponding failed workflow as reference: Should produce the same output as: |
mhalk
changed the title
Collaborator
Author
|
Maybe applying |
Collaborator
Author
|
fixup: |
Collaborator
|
I don't think we settled on using |
Collaborator
Author
Check; dropping that part of the work for both affected PRs (for now). |
mhalk
force-pushed
the
amd/dev/mhalkenh/nfc/shellcheck-compliance-aomp-common-vars
branch
from
September 23, 2026 13:55
df9b458 to
3611c05
Compare
jplehr
approved these changes
Sep 24, 2026
jplehr
changed the title
Collaborator
Author
|
Thanks for the approval and title correction! :) |
mhalk
deleted the
amd/dev/mhalkenh/nfc/shellcheck-compliance-aomp-common-vars
branch
September 24, 2026 11:44
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Unrelated changes caused GH pre-merge CI to fail
shellcheckcheck.Modernize formatting via shfmt.
Technical Details
Record once that the file defines variables for the scripts that source it, so their uses are invisible to static analysis, and quote the two expansions flagged for word splitting. Neither has an effect.
Quoting the array element in shquot also stops an argument holding a tab or a newline from being split into several quoted words. That output is meant to be pasted back into a shell, where the split silently alters the command.
Test Plan
Use run script which sources this file as usual.
Test Result
Executed script works as expected.
Submission Checklist