Skip to content

feat(megatron): enable Run Deck for training sweeps - #427

Draft
atnair-amd wants to merge 2 commits into
mainfrom
atnair/megatron-run-deck-a3e1
Draft

atnair-amd wants to merge 2 commits into
mainfrom
atnair/megatron-run-deck-a3e1

Conversation

@atnair-amd

Copy link
Copy Markdown
Collaborator

Adds a render-only sweep Run Deck for Megatron training stems (megatron_single, megatron_distributed, and the Llama 8B/70B variants via profile aliases).

Plan / code surfaces

  • Profile profiles/megatron.json with dataset_builder: sweep and layout: named_cells
  • Session fixtures (train_res_dict, rundeck_variant) in megatron conftest plus the four legacy Llama suite files
  • Sweep builder/renderer extended for named training cells (not ISL/OSL inference shapes)
  • Training gates unchanged; token-interactivity viewer off

Graphs / tables

  • TFLOP/s per GPU and tokens/s per GPU vs named cells
  • Threshold gate matrix
  • Full results table
  • Run card: model, GPU, nodes, parallelism

Review follow-up

  • Legacy rundeck_variant GPU/topology mismatches return None instead of erroring the module
  • Sweep decks still publish without variant metadata
  • bar_pct uses the same numeric/value guard as cell records
  • Single-cell charts render; x labels use {x} (compatible with the RCCL deck)
  • Display labels and extra-metric names come from profile dimension_keys / metric_prefix
  • Min gates use the worst sample; crashed combos appear as na rows

Quality

make fmt-check / make lint clean. Hardware not run. Draft — do not merge yet.

Note: this PR still touches shared sweep chart/gate-matrix code; review that path against vLLM/SGLang decks.

Supercedes #421.

Open in Web Open in Cursor 

A GPU or topology mismatch in the legacy Llama lookup now returns None
instead of erroring every test during module setup. Named-cell charts
accept a single point, bar_pct reuses the numeric guard, crashed combos
stay visible as na, and min gates use the worst sample. Chart x labels
use the same {x} template as other decks.
@cursor
cursor Bot force-pushed the atnair/megatron-run-deck-a3e1 branch from a722552 to 76e481c Compare September 15, 2026 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant