feat(megatron): inherit sweep MBS/GBS/precision from train_params and pass Primus TP/PP - #449
Merged
Merged
Conversation
… pass Primus TP/PP Require those fields on train_params, fill combo gaps from the cell key, and emit Primus tensor/pipeline parallel CLI flags.
…omitted Drop the hardcoded 2/128/BF16 fallback from docs and configs, and reject empty sweep.runs at load.
solaiys
approved these changes
Sep 18, 2026
solaiys
left a comment
Collaborator
There was a problem hiding this comment.
LGTM.
Reviewed sweep-key parsing, implicit default requiring train_params MBS/GBS/precision (no 2/128/BF16 fallback), empty sweep.runs rejected at load, combo overlays, and Primus --tensor_model_parallel_size / --pipeline_model_parallel_size. Packaged JSON and docs match. No blocking issues.
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MBS/GBS/PRECISIONfrom the combination key (and matching body overlays). Whensweepis omitted, the implicitdefaultcell requirestrain_params.micro_batch_size,global_batch_size, andprecisioninstead of falling back to 2 / 128 / BF16.training_iterations,tensor_parallelism,pipeline_parallelism); Primus now passes--tensor_model_parallel_sizeand--pipeline_model_parallel_size.sweep.runswith non-emptycombinationsfails at load. Packaged Megatron JSON and docs match this behavior.Test plan
sweepwith completetrain_paramsMBS/GBS/precision: onedefaultcelltrain_paramsfields with no sweep: load errorsweep.runswith declared combinations: load errortrain_params/ combo overlay