Repository navigation
fix(ci): skip the benchmark PR comment on fork PRs - #103
Merged
Merged
Conversation
A fork PR's GITHUB_TOKEN is read-only regardless of the permissions block, so the comment step 403s and fails a check whose benchmarks all ran (PR #102). Gate both comment steps on a same-repo head and always write the results table to the job summary, so fork PRs still show it. Agent-Harness: claude-code 2.1.278 Agent-Model: claude-opus-5[1m] Agent-Review: unreviewed Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Contributor
|
Contributor
Benchmark ResultsTime
Memory and allocations
Benchmark PlotsA plot of the benchmark results have been uploaded as an artifact to the workflow run for this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A PR from a fork always gets a read-only
GITHUB_TOKEN, whatever the workflow'spermissionsblock asks for — GitHub does this so untrusted code can't write to the base repo. The benchmark job's last step posts a comment, so on a fork PR it 403s and turns the whole check red even though every benchmark ran fine (first seen on #102).This gates the two comment steps on the head repo being this repo, and always appends the results table to the job summary, so fork PRs still get their numbers — just on the run page instead of in the thread.
It does not fix #102's current benchmark failure, which is separate: that PR bumps the package to 0.2.0 and sets
MatrixFreeOperators = "0.2"inbenchmark/Project.toml, and benchpkg reuses that env for the 0.1.0 baseline rev, so the baseline can't resolve. That has to be fixed on #102's own branch.—
🤖 Filed by Claude, so Kyle's benchmark bot and Kyle's PR bot aren't just two tabs of the same person arguing.
claude-fable-5-1 (high) · claude-code 2.1.278 · unreviewed