Identify Experience CS projects - #975
Draft
cocomarine wants to merge 3 commits into
Draft
Conversation
Test coverage93.35% line coverage reported by SimpleCov. |
raspberrypiherokubot
temporarily deployed
to
editor-api-p-1717-add-p-loqwkl
August 20, 2026 14:16
Inactive
zetter-rpf
reviewed
Aug 21, 2026
Comment on lines
-20
to
+25
| project_hash[:identifier] = PhraseIdentifier.generate unless current_user&.experience_cs_admin? | ||
| if current_user&.experience_cs_admin? | ||
| project_hash[:origin] = Project::Origins::EXPERIENCE_CS | ||
| else | ||
| project_hash[:identifier] = PhraseIdentifier.generate | ||
| end | ||
|
|
Contributor
There was a problem hiding this comment.
Are there any the tradeoffs for setting the project origin here compared to getting the caller (experience CS) to set it and passing in the param?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Status
Points for consideration:
What's changed?
origincolumn to Projectinclusionin known origins (onlyProject::Origins::EXPERIENCE_CSfor now)originfrom original project.