Repository navigation
Conversation
added 4 commits
September 12, 2026 04:12
…st behind GLAYOUT_CI
…client stall); decode TimeoutExpired bytes
carloscl03
added a commit
to carloscl03/gLayout
that referenced
this pull request
Sep 14, 2026
PR ReaLLMASIC#125 has the better diagnosis. The tutorials wrap generation in `with widgets.Output():`, and under headless nbconvert that capture makes nbclient wait out the full per-cell timeout even though the kernel is already idle -- 10 min per widget cell against 11 s without it. That is a far larger effect than anything measured here. My own A/B was confounded: removing `display_component` removed the multi-MB SVG *and* the widget-capture cell at the same time, so it could not tell them apart. And stripping the displays changed what CI exercises -- the drawing path stopped being covered at all -- where ReaLLMASIC#125 keeps the displays and disables only the capture. Theirs is the better fix, and `_strip_displays` inserted at the same line of run_tutorial_notebooks.py that ReaLLMASIC#125 inserts into, so this also removes the conflict. Kept, because ReaLLMASIC#125 does not have them and they are independent of which diagnosis is right: - jupyter-client==8.9.1, plus a step that enforces it on cache hits. The cache key hashes setup.py and src/, not the workflow, so a pin written only in the install step is inert when the venv is restored. That is how 8.10.0 got in: a src change busted the key on 2026-08-28 and the cold rebuild took the version published that morning. - --retries 1 for the crash/timeout class only. A failing cell is never retried, so a genuinely broken notebook still fails every try.
Contributor
|
Looks clean. Can you add a description of the new GLAYOUT_CI flag or give it a better name? (like a name that self-describes the purpose of the flag; it seems to be related to PEX). |
Contributor
Author
|
Fixed the name according to its purpose. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Under headless nbconvert, that capture makes nbclient wait out the full per-cell timeout after every widget cell even though the kernel is already idle, so each notebook took 10 min per widget cell instead of seconds. The workflow forced the gdstk backend for all notebooks, but most of them import Component/rectangle directly from gdsfactory, so a gdstk-backed nmos() handed to a gdsfactory container failed.
Each notebook gets its own matrix job with a 30-minute budget, with the runner's own timeout set below the job cap so a report is always produced. The backend is selected per leg: gdstk for GLayout_Cells and glayout_opamp, gdsfactory for the others. A slow cell is now reported by name instead of as an opaque crash.