Skip to content

Accept IPA input #312

Description

@roedoejet

Support aligning input that's already in IPA (e.g. eng-ipa)

Summary

readalongs align currently rejects IPA input. If you have a text file
that's already been g2p'ed into IPA (for example by a g2p engine that
isn't supported by g2p), there's no way to align it. We should support
-l eng-ipa (and other *-ipa langs) as valid alignment input.

Cause

get_arpabet_langs() in g2p/__init__.py explicitly filters out any
lang ending in -ipa, so these are never offered as valid inputs.

Proof of concept

Removing if not x.endswith("-ipa") in g2p/__init__.py makes readalongs align -l eng-ipa
work (confirmed working against a sandbox install of g2p)

Concerns for a proper solution

Simply un-filtering *-ipa langs pollutes readalongs langs, which
would then list every *-ipa variant (many with poor display names like
IPA, crg-ipa, crk-ipa). Ideally we'd accept *-ipa inputs
without listing them all in readalongs langs.

Priority

Low/medium

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions