Repository navigation
fix(bots): complete reviewed group continuation and Stop custody followups - #123
Conversation
૮ >ﻌ< ა ci reviewran on b9cdaa5 — merge: update PR 123 with protected main without source chan
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b9dd446fdc
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
1 participant
Scope
Successor to merged PR118: answer provenance, same-turn late peer continuation, released-worker backfill, Stop card fencing/visibility and the actual production group boundary. Existing default export exposes the test seam. Legacy fixtures retain assertions; hidden-session lifecycle fixture now binds the existing timer ports after installing fake timers.
Exact published source
Head:
b9cdaa52f7c55ff5a0f339f5df4bf3402c41070e.Tree:
375500b7abc63a849c86dbb19cf14f87ad12b890.Base: main after PR122 merge
0799bd8b8b2e94f915c7f77d8e267a75a3896be6.Final stacked tree:
cbabd9591dc00fdf8deed90aeb3e8b1dc5bd2ebc.Final review follow-ups
The current stack includes all five PR121 composer findings, both PR123 late/cold continuation findings, and all three PR124 draft/history/legacy-compaction findings. An independent native tool-boundary counterexample was also reproduced and repaired. Owner packets retain their causal red/green evidence and exact rollback.
Final exact composition
ce59fccd74ef184612fa01d477605dae36052a44/ treecbabd9591dc00fdf8deed90aeb3e8b1dc5bd2ebcpassed 733 Python tests/28 files,194 UI tests/9 files,863 bot cases/92 files, full renderer TypeScript, and lint with zero errors (six existing padding warnings). Every tracked source file, index tree and57 frozen pins matched before/after. Independent composed review passed with no material findings, preserving all16 earlier packets/207 historical rows with29 declared overlay rows. All18 changed paths have exact forward/reverse replay.Hosted checks for this new main-synchronized head are running. Prior-head green is historical.
Earlier qualification receipts
The final stacked source passed142 Python tests across8 files and35 UI tests across3 files, changed UI lint with zero output and full desktop TypeScript checking. All nine catalog postimages are byte-identical in this PR and the final stack. Independent bounded review found no remaining source blocker; the final pin/coverage report retains16 accepted packets with explicit overlays and no omission.
Broader compatibility:125 passed/2 skipped, with17 local Ollama HTTP fixture cases blocked at AF_INET socket creation. A filtered rerun excluding that socket fixture class passes; this is not a full socket integration claim. Earlier failed attempts remain recorded. Hosted exact-head checks are running; prior-head green checks do not qualify this head.
The unchanged production plugin passed844/844 Node cases across91 files at predecessor9f04. Final source adds only the timer fixture binding in this scope; actual hidden-session load/reconnect/REST ownership/disposal assertions pass in the final35-case UI gate. Producer119/119 and causal14/25 are retained with their original scope.
Limits
Offline source qualification with inert provider/auth/transport seams, one worker and isolated synthetic home. No live provider/account/credential use, installed-app change, release selection, app lifecycle or activation action. The frozen source is available for inactive packaging; release readiness requires separate runtime/containment gates.
Rollback
Forward/reverse replay restores every prior stack tree exactly. After protected merge, use a reviewed
git revert -m 1 <actual-merge-commit>in reverse dependency order. No force reset or protection bypass.