Repository navigation
fix(native): preserve continuity, retire owned resources and retain partial outcomes - #124
Conversation
૮ >ﻌ< ა ci reviewran on 32b06d9 — merge: update PR 124 with protected main without source chan
|
Carry profile home and secret scope through catalog workers and cache refresh; exclude AWS SDK catalog prefetch. Retain reviewed native/group/provider/dial fixes. Timer fixture binds the existing runtime seam without altering assertions.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 53fe74d9ac
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…nd scoped legacy compaction
1 participant
Scope
Successor to merged PR117: compaction ACK/thread continuity, native turn model/history continuity, local resource retirement preserving successor aliases and truthful result-only partial consumers across CLI, gateway, API and TUI. All 17 producer postimages remain exact, with reviewed catalog/group/provider/dial repairs through ancestry.
Exact published source
Head:
32b06d918303c952fe8e7befec578308ee3e1669.Tree:
cbabd9591dc00fdf8deed90aeb3e8b1dc5bd2ebc.Base: main after PR123 merge
f09cbbd8fa15f3ef44dde9b340e3ec7142e9e79a.Final stacked tree:
cbabd9591dc00fdf8deed90aeb3e8b1dc5bd2ebc.Final review follow-ups
The current stack includes all five PR121 composer findings, both PR123 late/cold continuation findings, and all three PR124 draft/history/legacy-compaction findings. An independent native tool-boundary counterexample was also reproduced and repaired. Owner packets retain their causal red/green evidence and exact rollback.
Final exact composition
32b06d918303c952fe8e7befec578308ee3e1669/ treecbabd9591dc00fdf8deed90aeb3e8b1dc5bd2ebcpassed 733 Python tests/28 files,194 UI tests/9 files,863 bot cases/92 files, full renderer TypeScript, and lint with zero errors (six existing padding warnings). Every tracked source file, index tree and57 frozen pins matched before/after. Independent composed review passed with no material findings, preserving all16 earlier packets/207 historical rows with29 declared overlay rows. All18 changed paths have exact forward/reverse replay.Hosted checks for this new exact head are running; previous-head green is historical. Offline consumer tests use inert provider/wire/executor/audio seams. Parent owns packaged runtime/containment acceptance; no activation or release-ready claim follows from these source gates.
Earlier qualification receipts
The final stacked source passed142 Python tests across8 files and35 UI tests across3 files, changed UI lint with zero output and full desktop TypeScript checking. All nine catalog postimages are byte-identical in this PR and the final stack. Independent bounded review found no remaining source blocker; the final pin/coverage report retains16 accepted packets with explicit overlays and no omission.
Broader compatibility:125 passed/2 skipped, with17 local Ollama HTTP fixture cases blocked at AF_INET socket creation. A filtered rerun excluding that socket fixture class passes; this is not a full socket integration claim. Earlier failed attempts remain recorded. Hosted exact-head checks are running; prior-head green checks do not qualify this head.
Producer final acceptance332/332 across13 files is sealed. Historical composition547/547 across20 files at79a06 preserves all17 implementation/test postimages here; the final native+catalog composition gate passed689/689 across28 files on exact b58 source hashes. Independent supplement accepted that receipt, retaining the runner metadata correction and all proof limits. API tests use inline scheduling with real handlers/native producer/temp DB; socket HTTP sibling tests cannot run here. External shutdown hooks/manual borrowed primary clients/unattached resources and extra once fast paths retain their original limits.
Limits
Offline source qualification with inert provider/auth/transport seams, one worker and isolated synthetic home. No live provider/account/credential use, installed-app change, release selection, app lifecycle or activation action. The frozen source is available for inactive packaging; release readiness requires separate runtime/containment gates.
Rollback
Forward/reverse replay restores every prior stack tree exactly. After protected merge, use a reviewed
git revert -m 1 <actual-merge-commit>in reverse dependency order. No force reset or protection bypass.