Repository navigation
fix(collaboration): allow identical closed projection rebuilds - #126
Draft
RecursiveIntell wants to merge 1 commit into
Draft
RecursiveIntell wants to merge 1 commit into
RecursiveIntell wants to merge 1 commit into
Conversation
૮ >ﻌ< ა ci reviewran on 26c20f0 — fix(collaboration): allow identical closed projection rebuil
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Rebuilding a closed closure projection from identical owner evidence currently raises
REOPEN_REQUIRES_NEW_EVIDENCE. Allow an identical, schema-validated full artifact to rebuild with the same canonical bytes and digest. Any changed closed artifact still requires a new source event.Related Issue
Source-supported pure closure review finding. The schema describes a rebuildable derived projection; no deployed consumer or attribution to the active Ares incident has been established.
Type of Change
Changes Made
ares_runtime/collaboration.py: compare the complete validated projection to its prior artifact after existing lineage and source-existence checks.How to Test
scripts/run_tests.sh -j 1 --file-retries 0 --file-timeout 90 tests/ares_runtime/test_closure_projection_rebuild.py -q scripts/run_tests.sh -j 1 --file-retries 0 --file-timeout 90 tests/test_ares_collaboration.py -q -k 'test_skipped_required_check_is_not_closed or test_missing_source_event_is_rejected or test_ambiguous_effect_is_quarantined or test_reopen_requires_a_new_evidence_projection'Exact focused tree
5f00d9576299a00dab2ccf3648983aaaed0eb4d8passed 12 new tests plus four existing controls, zero failures, one worker and zero retries. Original implementation with the same final new test file has three causal failures and nine passing controls. A fresh independent source reviewer found no blocking findings.Linux offline execution used a disposable source copy, hidden real home, temporary stores and Python network denial. A task-only interpreter shim skipped the optional bytecode cache prebuild for disk headroom; the canonical per-file runner and tests were unchanged. Source/index hashes stayed stable. Full-suite, installed application, provider/MCP and cross-platform runtime checks were not exercised.
Malformed flags or schema-invalid gates can now report validation errors before the former reopen error. They remain rejected; no inspected contract requires the prior error precedence. Mission/event stores retain mutation authority.
Checklist
Evidence and Rollback
Base
04997747879d54a242941d344c3a38293c307076, treecbabd9591dc00fdf8deed90aeb3e8b1dc5bd2ebc. Exact forward/reverse index replay restored the base. Reverse delta SHA256:e578cdbfa999a29c88aecd1f757d75d7e6d8427ff0800bb7825db6b1aef8eba4.Draft source proposal only. A future authorized rollback is reverting this focused commit; no activation, service, installed profile or live rollback action accompanies publication.