Repository navigation
fix(desktop): preserve group turn custody through Stop and rename races - #127
RecursiveIntell wants to merge 2 commits into
Conversation
૮ >ﻌ< ა ci reviewran on b4b752d — fix(desktop): reconcile group cancellation preparation and a
|
|
Reviewed follow-up to original failed hosted plugin job. The original seven assertion failures and 4 GiB heap OOM remain retained evidence. Preparation-time Stop now fences cancellation confirmation while preparation remains pending. A proven prompt admission refusal releases unused custody after preparation settles, with refusal state reset before each actual retry. Existing fixtures distinguish interrupt acknowledgement from terminal retirement; a bounded one-shot Stop fixture removes its own repeated-poll feedback. Accepted offline receipt: 346/346 cases across 12 files, independent review accepted, exact forward/reverse replay. The original hosted OOM cause remains unqualified until fresh hosted CI. No installed app, backend/provider or live Ares execution occurred. Revert follow-up commit to restore prior head Published head |
|
Published follow-up head Its managed-guard builder log reports |
This branch has not been deployed
1 participant
Group turns could lose accepted custody on a typed hold or interrupt ACK, wait for an execution worker after becoming terminal, or lose their collector across a rename. Preserve the captured turn until exact retirement, fence successor admission while any session interrupt is pending, and let terminal collection finish without reserving another worker. Stop now shows whether cancellation remains unconfirmed or turns are still retiring; approval success requires a positive resolved count.
Renames rehome the existing lifetime and commit all local membership/room/navigation intent before metadata awaits. Delayed settings saves follow the current lifetime and cannot recreate a deleted name or update a replacement room. Existing admission, durable receipt and backend ownership remain intact.
Validation: 152 focused offline cases pass against the exact production plugin through fake ports, including 12 pending-interrupt and overlapping/stale-settings counterexamples. Independent exact-source review passed. Forward/reverse patches are verified against pinned preimages and postimages. Core exact-head CI remains the next gate; live-provider cancellation, host-global capacity and installed-app activation were not exercised.
Draft source proposal only; not installed or activated. Revert this focused commit for rollback; exact reverse patch SHA256
f1a2e23749e23940e7cd8af59d8a2ed8572dff2004aacf6da3c59d2dda1c4563restores the pinned base from these postimages. The four-worker limit is per room, not a host-wide capacity claim.