Repository navigation
fix(desktop): preserve model picker source and receipt ownership - #133
Draft
RecursiveIntell wants to merge 1 commit into
Draft
RecursiveIntell wants to merge 1 commit into
RecursiveIntell wants to merge 1 commit into
Conversation
૮ >ﻌ< ა ci reviewran on 43915b3 — fix(desktop): preserve model picker source and receipt owner
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Model settings mounted for source A could survive a switch to B with the same profile name, then send a resumed confirmation to B. Fresh-draft picker catalogs could also follow foreground A while admission belonged to pending/failed target B, and valid model-only receipts could be hidden by stale catalog pairs.
Bind settings form lifetimes and reads/writes/confirmations to the canonical source, profile and target. Capture each draft's logical owner in both inline and overlay catalog producers; late replies stay in their origin cache. Keep authoritative scalar model receipts visible. Distinguish legacy null source from forced local in keys and requests, preserving explicit null through the API helper and picker producers so RPC fallback cannot silently select another source.
The final 18-path tree
f123160235236b4bd853e7fc336b5e87a46bce1epasses 172/172 cases across 11 files, renderer/API types and lint for all 18 changed paths. Final independent source review accepted the exact tree. The final fixture correction changes only the legacy-null expectation and two padding newlines; the prior 17 accepted paths remain byte-identical. Earlier failed copy, test and lint receipts remain retained. The supported selector categories were exercised with inert transports; these results do not qualify live providers or current Ollama bindings.Runtime admission/deferred/once semantics remain owned by the backend. This draft should be composed with #130 and the still-open #102 model/cold-history work before merge; no standalone integration-readiness claim is made. Actual Electron main IPC, spawn/secrets, Electron-project types, current installation, live UI/provider execution and release readiness remain unqualified. Historical installed pins are not current-running-source evidence.
Base
04997747879d54a242941d344c3a38293c307076, treecbabd9591dc00fdf8deed90aeb3e8b1dc5bd2ebc. Forward/reverse replay reconstructs the exact final and base trees. Reverse patch SHA256705423e108b2f1521477bd98f3be023d8c2d1ef99672c26a059469c1130e8a30restores only these reviewed paths. No activation, installation, service change or live rollback accompanies publication. Hosted CI is a separate gate.