Repository navigation
fix(ares): integrate reviewed repair composition and native CI gates - #136
Draft
RecursiveIntell wants to merge 2 commits into
Draft
RecursiveIntell wants to merge 2 commits into
RecursiveIntell wants to merge 2 commits into
Conversation
Publish the exact independently reviewed composition for draft integration qualification. Local source commit: e1ac2ecc9c00aec714a7b771e337f249cbe5293c Exact source tree: 2aa4d4e Base: e3e8a39 This connector-created commit has a distinct identity from the local source commit. No merge, install or activation.
૮ >ﻌ< ა ci reviewran on 3f52dac — fix(ares): repair PR136 owner and CI contracts
|
| Package | Before | After |
|---|---|---|
| electron | 41.10.3 |
41.10.6 |
How to fix:
Add the ci-reviewed label after verifying the version changes are expected.
⚠️ Warnings
OSV vulnerability scan · View job
118 known vulnerabilities found in pinned dependencies.
- CVE-2026-103923 in package-lock.json
- CVE-2026-103923 in website/package-lock.json
- CVE-2026-104851 in uv.lock
- CVE-2026-84947 in package-lock.json
- CVE-2026-84947 in plugins/platforms/photon/sidecar/package-lock.json
- CVE-2026-101917 in uv.lock
- CVE-2026-84933 in package-lock.json
- CVE-2026-84933 in plugins/platforms/photon/sidecar/package-lock.json
- CVE-2026-103261 in uv.lock
- CVE-2026-85024 in package-lock.json
- CVE-2026-85024 in package-lock.json
- CVE-2026-85024 in plugins/platforms/photon/sidecar/package-lock.json
- CVE-2026-84890 in package-lock.json
- CVE-2026-84890 in plugins/platforms/photon/sidecar/package-lock.json
- CVE-2026-101918 in uv.lock
- CVE-2026-104874 in uv.lock
- CVE-2026-84394 in package-lock.json
- CVE-2026-84394 in website/package-lock.json
- CVE-2026-104848 in website/package-lock.json
- CVE-2026-64847 in uv.lock
How to fix:
Review the findings in the Security tab. Update the affected dependencies if a patched version is available.
debug info
CI timings
CI timings · View report · View job
Wall time 8m1s vs 6m49s (+17.6%). 24 job(s) slower, 20 faster,
- Python tests / Run tests slice 7/12: +51.0s
- JS & TS checks / apps/desktop / check:test:ui:shard-2of3: +42.0s
- Python tests / Run tests slice 8/12: +36.0s
- JS & TS checks / apps/desktop / check:test:ui:shard-3of3: -35.0s
- Python tests / Run tests slice 10/12: +33.0s
Publish the independently accepted13-path successor as a fast-forward review commit. Local reviewed commit: cec4f1eb4fca5fa780579d02ea3b6b163806e0a8 Exact reviewed tree: 1c4dea4 Parent remote commit: 01b1e1e Canonical28-file local proof:1124 normal passes and51 separate subtest passes; Python3.13 and new-head hosted qualification remain pending. No merge or activation.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Integrate the reviewed Ares repair composition and its independently accepted 13-file CI repair successor for hosted qualification.
The successor fixes canonical admission transport precedence in
_run_prompt_submit: explicit queued transport first, then the captured canonical owner, then inherited context. The conversation-loop change preserves the native-refusal veto and fallback/restart behavior while retaining the direct guarded fallback callsite. Updated behavior tests and owner fixtures exercise current ingress, Stop/generation, named-profile/LSP, cron custody, optional-native import/setup cleanup, and real conversation fallback/preflight. Seven new witnesses run against the actual combined source.The underlying composition includes authority/closure/group custody, MCP readiness diagnostics, context admission/budgets, model intent/picker ownership, explicit Stop handling, Electron and native transport/runtime/tool/gateway repairs; awaited desktop title and visibility exhaustion checks; strict npm diagnostic schema v2; Nix and native CI qualification gates.
Exact current source binding
e3e8a39d9427354eeba014c21c9c916078fb0cdb01b1e1e7ea67f3b037cc2a76722a993a7335bf1bcec4f1eb4fca5fa780579d02ea3b6b163806e0a83f52dac495e0506fc783af2704afab5c99405b0e1c4dea4c1149b332f9b6673086bf1797cc52173fThe supported connector creates a distinct commit identity while preserving the complete reviewed tree. The 13-path delta is a fast-forward from the original publication; all other tree entries, current-main README, package manifests and lock inputs remain unchanged. Existing component drafts #125–133 and related #102/#84/#78 remain open. The overlapping Undici dependency repair in #135 is separate and untouched.
Validation
Canonical
scripts/run_tests.shon the exact combined local source ran 28 complete files: 1,124 normal tests and 51 separate subtests passed, zero failures/skips; one worker, zero retries, 300 seconds/file. All seven new witnesses passed. Independent execution review accepted the source, collection, actual constructor/loop/helpers/fixtures and resident-module bindings. The proof uses Python 3.11.16 with the existing smaller task extras. The successor's hosted context-focused job subsequently passed on CPython 3.13.11 (3,131 passed, 0 failed, 6 skips). The transport full-suite slice reports CPython 3.11.14. These results do not establish complete Python 3.13 coverage of all G2/full-suite tests.The original head's failed CI and the first task-provenance capacity failure are preserved; neither receives passing successor credit. Controlled optional-native exports, inert clients and disclosed denied network attempts bound the local proof. It does not qualify the native ABI, configured Governor, real providers/services, package/install or live runtime.
Remaining gates and rollback
Hosted run 37534138786 is terminal: all 12 full Python slices, focused context tests, native paired-source, current-owner integration, JS checks and lints passed. The aggregate observed
native_external_owner_result=success,focused_tests_result=successandprofile_runtime_consumer_result=success. Pinned actionlint 1.7.11 installation/checksum and workflow lint passed. Separate Nix run 37534137204 passed.All required checks passremains failed solely because the review-label gate failed:ci-reviewedis absent. It requires actual maintainer review of the CI-sensitive files. No label or CI rerun was applied. Desktop E2E remains disabled. Existing native dependency pins remain unchanged; the Recursive Agent diagnostic draft is not adopted.The exact reverse delta restores parent
01b1e1e7ea67f3b037cc2a76722a993a7335bf1b/ tree2aa4d4e9cff1248b50f6c8e1fdeb7801cc44756e; reverse patch SHA256c0e8d950d2ce6053abaa704255a9f78a3addf9fd8f2bfe92d54461a856f88bb7. Forward patch SHA2564414fe2d4cfcc0fb6dc1b6e03de387e0ada4e41f350b26e83c16b6e6f197ade8. Independent replay verified all 13 paths and unchanged entries.Final seal SHA256:
947bac4a499b27f5409d0e0f65a187c4c5e757723791b0feea6c3633a56032c2. Independent combined execution review SHA256:2b3cd1dd05eaaebe7a7fba76183f08038f08bade5c7b49e437bba1666c6e6deb.npm v2 historical producer/reader migration, inactive package/backout qualification, refreshed owner preflight and bounded canary remain separate gates. Draft only; no merge, deployment, activation or live Ares action.