Skip to content

Fix CI failure on setup-php 2.40.0 bump (PR #8) #13

Closed

Description

@jayjfletcher

Problem

Dependabot PR #8 (bump shivammathur/setup-php to 2.40.0) fails the P8.5 / L13.* / prefer-stable / ubuntu-latest CI job.

Outcome

PR #8's checks go green.

Out of scope

Merging PR #8.

Activity

  1. jayjfletcher commented on Oct 28, 2026

    @jayjfletcher
    MemberAuthor

    D-002 (answered in RingMaster): rebase PR #8 and re-run first; change only the workflow if it still fails. If the rebased run fails on composer resolving paratest, wait for the campaign PR that drops Cortex's paratest conflict rather than fixing it here.

  2. jayjfletcher commented on Oct 28, 2026

    @jayjfletcher
    MemberAuthor

    Decisions recorded (answered in RingMaster): D-003 if the rebased run still fails on the PHPStan bootstrap race, open a separate PR against main with the fix, then rebase PR #8 onto it. D-004 two consecutive green runs on the same head (re-run once) count as proof. D-005 if Dependabot does not rebase PR #8, rebase manually and push to the PR branch.

  3. jayjfletcher commented on Oct 28, 2026

    @jayjfletcher
    MemberAuthor

    Baseline before rebase: PR #8 head 1e4ef79, main tip 259c86c. Failing job: https://github.com/Refactor-Circus/Cortex/actions/runs/38800233800/job/116647049225 — error: require(.../vendor/orchestra/testbench-core/laravel/bootstrap/cache/packages.php): Failed to open stream (parallel worker, exit 1). Posting @dependabot rebase on PR #8 next.

  4. jayjfletcher commented on Oct 28, 2026

    @jayjfletcher
    MemberAuthor

    PR #8 head 2567b56 is already based on the current main tip (259c86c), so a rebase changes nothing. The failing run (https://github.com/Refactor-Circus/Cortex/actions/runs/40619686369) fails in the composer install step on all four P8.5/L13.* jobs, with no setup-php involvement:

    - Root composer.json requires pestphp/pest ^5.3.1 -> satisfiable by pestphp/pest[v5.3.1 .. v5.3.4]
    - pestphp/pest v5.3.2-v5.3.4 require brianium/paratest ^7.26.1+
    - refactor-circus/cortex conflicts with brianium/paratest v7.27.1-v7.27.4 (composer.json "conflict": brianium/paratest >=7.26.1)
    - pestphp/pest v5.3.1 conflicts with phpunit/phpunit 13.4.5
    

    The same failure applies to main, so it is not caused by the setup-php bump. Per the spec (criterion 4) no fix is made here: the conflict entry for paratest in composer.json has to be dropped in its own PR. This job is released as blocked until that PR is merged, then PR #8 gets rebased and re-run.

  5. jayjfletcher commented on Oct 28, 2026

    @jayjfletcher
    MemberAuthor

    Ring Master: using this issue for the job "Drop brianium/paratest conflict so composer resolves with Pest 5.3" (composer.json conflict on brianium/paratest >=7.26.1 blocks resolution with Pest 5.3, which breaks the P8.5 / L13.* jobs).

  6. jayjfletcher commented on Oct 28, 2026

    @jayjfletcher
    MemberAuthor

    Decision D-002 (answered in RingMaster): the standards for this change are architecture/dependencies only. Only composer.json constraints change, so no other standard applies.

  7. jayjfletcher commented on Oct 28, 2026

    @jayjfletcher
    MemberAuthor

    Baseline and result for PR #8 (setup-php 2.40.0):

    • main tip: 259c86c. PR Bump shivammathur/setup-php from 2.37.2 to 2.40.0 #8 head: 2567b56 (already rebased; merge-base equals the main tip). Diff is only .github/workflows/tests.yml.
    • Run on that head: https://github.com/Refactor-Circus/Cortex/actions/runs/40619686369 — all four matrix jobs red.
    • The failure is not caused by setup-php 2.40.0. The composer require "laravel/framework:13.*" "orchestra/testbench:11.*" --no-update step fails resolving:
      • refactor-circus/cortex (this package's own conflict on brianium/paratest) conflicts with paratest v7.27.1-v7.27.4
      • pestphp/pest ^5.3.1 needs paratest ^7.26.1 / ^7.27.4 (v5.3.1 conflicts with phpunit 13.4.5)
    • The earlier PHPStan "Laravel framework bootstrap failed" error from run 38800233800 (old head 1e4ef79) did not recur, because CI now stops before composer analyse.
    • Fix is the paratest conflict, tracked in spec 2026-10-27-2251-drop-paratest-conflict-for-pest-5-3 (waiting on a decision; no PR yet). No change made on PR Bump shivammathur/setup-php from 2.37.2 to 2.40.0 #8. Releasing the task as blocked on that campaign.
  8. jayjfletcher commented on Oct 28, 2026

    @jayjfletcher
    MemberAuthor

    Spec approved in RingMaster (D-005). Decisions: D-003 stop and report if dropping the conflict is not enough (no pest/phpunit constraint changes); D-004 PR must have the P8.5 / L13.* checks green. Spec: docs/agent/specs/2026-10-27-2251-drop-paratest-conflict-for-pest-5-3/

  9. jayjfletcher commented on Oct 28, 2026

    @jayjfletcher
    MemberAuthor

    Baseline check for PR #8 (setup-php 2.40.0), run 40619686369, head 2567b56874af751edb4be8233aaaf3c908f14391.

    PR #8 is still open and changes only .github/workflows/tests.yml. All four matrix jobs fail at composer update, not at anything setup-php does:

    refactor-circus/cortex dev-... conflicts with brianium/paratest v7.27.4 (and 7.27.3, 7.27.2, 7.27.1)
    pestphp/pest v5.3.1 conflicts with phpunit/phpunit 13.4.5
    pestphp/pest v5.3.4 requires brianium/paratest ^7.27.4
    

    Cause: Cortex's composer.json conflict on paratest blocks the paratest version Pest 5.3 needs. The setup-php bump is unrelated. No change is made on PR #8's branch.

    This is tracked by spec 2026-10-27-2251-drop-paratest-conflict-for-pest-5-3 (waiting on a decision, no PR yet). Pausing this job until that fix merges; then PR #8 gets a @dependabot rebase and a re-check.

  10. jayjfletcher commented on Oct 28, 2026

    @jayjfletcher
    MemberAuthor

    PR #8 is green after a rebase onto main (no file changes)

    Cause of the original failure: run 40619686369 failed in composer install on all four jobs with "Your requirements could not be resolved to an installable set of packages": pestphp/pest v5.3.4 requires brianium/paratest ^7.27.4, and Cortex at that point declared a conflict with paratest 7.27.x. setup-php 2.40.0 itself was not at fault. The conflict was dropped on main by #14.

    Rebase (criterion 1):

    • @dependabot rebase was posted on PR Bump shivammathur/setup-php from 2.37.2 to 2.40.0 #8 at 05:18Z. Dependabot did not respond; its earlier comment on the PR reports a dependabot.yml labels error (dependencies label missing), which may be why.
    • Per D-005, the branch was rebased manually onto the main tip and pushed with --force-with-lease.
    • Old head: 2567b56874af751edb4be8233aaaf3c908f14391 (merge-base 259c86c)
    • New head: 8a2bde7d74b0e8f78cbc322136dd29acda138189
    • Merge-base with main at push time: c914866015ce27e280a4a0fa07118e4f28f59313 (the main tip)
    • Note: because the rebase was manual, Dependabot will no longer rebase or update this branch on its own.

    Two consecutive green runs on the same head (criterion 2, D-004): run 40637729378, attempt 1 and attempt 2 (attempt 2).

    Job Attempt 1 Attempt 2
    P8.5 - L13.* - prefer-stable - ubuntu-latest success success
    P8.5 - L13.* - prefer-lowest - ubuntu-latest success success
    P8.5 - L13.* - prefer-stable - windows-latest success success
    P8.5 - L13.* - prefer-lowest - windows-latest success success

    The attempt 1 log has no "Failed to open stream ... packages.php" line. Race hypothesis unconfirmed: the PHPStan bootstrap error did not recur, so no workflow or PHPStan config change was made.

    Scope (criterion 6): git diff --name-only main...8a2bde7 lists only .github/workflows/tests.yml (the one-line setup-php bump). Nothing under src/ changed. PR #8 is not merged; merging is the maintainer's call.

  11. jayjfletcher commented on Oct 28, 2026

    @jayjfletcher
    MemberAuthor

    Decision D-007 (answered in RingMaster): PR #8 is green on two consecutive CI runs, so this job is marked done. The local gate drift (stale composer.lock read by KeenInCiTest, stale ringside generated files) goes into a follow-up task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions