Repository navigation
Extend Keystone's Action base and a CortexException root - #12
Merged
Merged
Conversation
Every action now extends RefactorCircus\Keystone\Actions\Action: callers
keep execute(), each action implements a protected handle(). Every
exception descends from the abstract CortexException (on Keystone's
PackageException), with new Invalid{Agent,Tool,McpServer}ClassException,
ImmutableVersionException and UnexpectedResultException replacing raw
SPL throws. ArchTest checks both.
Ported onto the ConcreteServer rename, including its new tool-override
actions.
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #11 (Ringside migration); retarget to
mainonce that merges.RefactorCircus\Keystone\Actions\Action: callers keepexecute(), each action implements a protectedhandle().RefactorCircus\Cortex\Exceptions\CortexException(on Keystone'sPackageException). NewInvalidAgentClassException,InvalidToolClassException,InvalidMcpServerClassException,ImmutableVersionExceptionandUnexpectedResultExceptionreplace raw SPL throws.tests/ArchTest.phpchecks both rules.ClearConcreteServerToolsActionandUpdateConcreteServerToolsAction.Locally: phpstan clean; Pest 655/656. The one failure,
KeenInCiTest"keeps refactor-circus/keen in require-dev with a lock entry", reads the untrackedcomposer.lock, which is stale in acomposer.local.jsoninstall; CI builds a fresh one.🤖 Generated with Claude Code