Skip to content

2026-10-29-2038-guardian-package: post-mortem - #2

Merged
jayjfletcher merged 2 commits into
mainfrom
ring-master/2026-10-29-2038-guardian-package-record
Nov 2, 2026
Merged

jayjfletcher merged 2 commits into
mainfrom
ring-master/2026-10-29-2038-guardian-package-record

Conversation

@jayjfletcher

Copy link
Copy Markdown
Member

Post-mortem for the Guardian package job (2026-10-29-2038-guardian-package, PR #1).

Summary

  • Factory run wf_e98c383c-d71 was approved in round 2. The gate passed 546 tests with 2043 assertions, PHPStan, Pint and 100% type coverage.
  • The run had 7 task groups and 22 decisions (5 raised during build or review). It had 1 major and 2 minor review findings, all fixed.
  • Most cost: a Roster-boundary violation that went unnoticed for 6 groups (criterion 9 didn't list Concerns, Resources or Support), and salvage or retry churn in groups 1–4.
  • Roster moved during the build: the linked Roster dropped SSO and SCIM mid-build, so criteria 22 and 28 were met with fixtures.

Record changes

  • Spec status changed from in-review to closed.
  • post-mortem.md added.
  • spec.md gains a v0.1.0 addendum: Keystone and siblings move to ^0.1, laravel/mcp to ^1.1, and criterion 28 is superseded by Roster v0.1.0.

Accepted standards proposals (queued for refactor-circus/standards)

Each file is in docs/agent/standards-proposals/global/:

  • actions/actions-events: read actions dispatch the event pair too, and only the action dispatches its own events (D-041).
  • models/migrations: adopted-tables pattern, with a hasTable() guard and a down() that refuses to drop tables with rows unless forced (D-031, D-040).
  • architecture/service-providers: a booting() registration for packages that stay inert without their host, and the {package}.ui.enabled requirement for registerAtriumPlugin() (D-038).
  • architecture/dependencies: a package-boundary rule. An add-on may use its host's seams and public domain API only.
  • testing/arch-tests: a package-boundary arch rule with a pinned dataset, and the action-event rule covering read actions.
  • errors/exceptions: override $status with public protected(set), never public readonly.
  • http/resources: a mirror resource held equal by a parity test when the package boundary forbids reusing the host's resource.

🤖 Generated with Claude Code

@jayjfletcher
jayjfletcher merged commit 3765377 into main Nov 2, 2026
8 checks passed
@jayjfletcher
jayjfletcher deleted the ring-master/2026-10-29-2038-guardian-package-record branch November 11, 2026 04:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant